test(e2e): parse result.stdout for JSON to avoid stderr contamination#819
Merged
Conversation
The inspect/run/config E2E helpers parsed result.output, which under Click 8.4 interleaves stderr into stdout. After #793 made the logger attach a real stderr handler, -v/--verbose INFO lines landed in result.output and broke json.loads (JSONDecodeError on the leading log line). Parse the dedicated result.stdout channel instead, matching how real JSON consumers read these commands. - test_inspect_e2e.py: fixes the failing -v / -v-short tests (3 sites) - test_run_e2e.py: hardens 8 naive json.loads(result.output) sites - test_config_e2e.py: read stdout in _run_config (used by test_verbose_flag)
zhenchaoni
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inspect/run/config E2E helpers parsed result.output, which under Click 8.4 interleaves stderr into stdout. After #793 made the logger attach a real stderr handler, -v/--verbose INFO lines landed in result.output and broke json.loads (JSONDecodeError on the leading log line). Parse the dedicated result.stdout channel instead, matching how real JSON consumers read these commands.