Standardize product naming to "WinML CLI" (#510)#818
Open
ziyuanguo1998 wants to merge 1 commit into
Open
Conversation
Pick one canonical scheme and apply it to every user-visible surface: - "WinML CLI" - the product/tool name - "winml" - the literal command - "Windows ML" - the OS platform models deploy to Changes: - winml --version now prints "WinML CLI, version X" (was "winml, version X") - Top-level help description uses "Windows ML" for the platform instead of bare "WinML" - pyproject description and README lead-in aligned to the scheme - Normalize "winml CLI" -> "WinML CLI" in package/command/serve docstrings - Add test locking the canonical product name in --version output "Windows ML" is left intact where it refers to the OS platform/runtime, and "WinML Inference Class" is kept as a technical term in inspect output.
xieofxie
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #510 — multiple brand spellings (
WML,WinML,winml,Windows ML) appeared inconsistently across user-visible output.WML/WML ModelKitwere already gone and the codebase had mostly standardized onWinML CLI. This PR finishes the job by enforcing one canonical scheme everywhere:WinML CLI— the product/tool namewinml— the literal commandWindows ML— the OS platform models deploy toChanges
User-visible
winml --versionnow printsWinML CLI, version 0.1.0(waswinml, version 0.1.0)--helpdescription usesWindows MLfor the platform instead of bareWinMLpyproject.tomldescription →Accelerate Model Deployment on Windows MLREADME.mdlead-in**Windows ML CLI**→**WinML CLI**(matches the title)Internal docstrings normalized (
winml CLI→WinML CLI): package__init__, command modules (analyze/compile/export/optimize/quantize),utils/console.py, and theservemodule.Test — added
test_version_uses_canonical_product_namelocking the canonical product name in--versionoutput.Left intentionally unchanged
Windows MLwhere it refers to the OS platform/runtime (banner subtitle,sysOS-service detection,device.pyORT-build comments, README platform descriptions)WinML Inference Class— a technical term ininspectoutput🤖 Generated with Claude Code