Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yaml manifest schemaheader validation for V.1.10.0 and above #5126

Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
8b9fce6
Add schema header validation for YAML manifests V.1.10.0 and above
Madhusudhan-MSFT Jan 12, 2025
4db7583
Treat schema header validation errors as warnings for 'winget validat…
Madhusudhan-MSFT Jan 12, 2025
c60d267
Add tests for YAML Manifest schema header validations
Madhusudhan-MSFT Jan 12, 2025
c8e69e3
Extend Add schema header validation tests for WinGet CLI Validation c…
Madhusudhan-MSFT Jan 12, 2025
8065a7a
Update error message in ManifestV1_10 test case
Madhusudhan-MSFT Jan 12, 2025
f594f1b
Fix typo in test manifest file path in two test files
Madhusudhan-MSFT Jan 12, 2025
1d27243
Enhance YAML manifest schema header validation
Madhusudhan-MSFT Jan 12, 2025
bd4fd24
Fix casing in YAML language server schema URL comment
Madhusudhan-MSFT Jan 12, 2025
4b18e9e
Fix casing in YAML language server schema URL to address ValidateV1_1…
Madhusudhan-MSFT Jan 12, 2025
097ee92
Addressing PR review comments: Simplify schema header validation erro…
Madhusudhan-MSFT Jan 14, 2025
7d9c4f2
Fix formatting issues in ValidateCommand.cs
Madhusudhan-MSFT Jan 14, 2025
ea00978
[PRFeedback:] Refactor YAML schema header handling
Madhusudhan-MSFT Jan 15, 2025
8607fbb
Fix typo in AddSchemaHeader parameter name
Madhusudhan-MSFT Jan 15, 2025
91f1fb2
Fix visual studio editor introduced encoding character issue with the…
Madhusudhan-MSFT Jan 15, 2025
ad62417
Revert chagnes ValidateCommand.cs and replacing it with orginal file …
Madhusudhan-MSFT Jan 15, 2025
001e610
Bring back validatecommand schema header tests.
Jan 15, 2025
812f547
PRFeedback: Refactor YAML schema handling and improve maintainability
Madhusudhan-MSFT Jan 17, 2025
db264b6
Optimize YamlParser with move semantics
Madhusudhan-MSFT Jan 17, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix casing in YAML language server schema URL comment
Updated the URL in the comment for the YAML language server schema to correct the casing of "defaultLocale" to "defaultlocale". This ensures the schema URL is correctly referenced.
Madhusudhan-MSFT committed Jan 12, 2025
commit bd4fd2487e28c0dca4ca1117536e2185b4c8c5d9
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultLocale.1.10.0.schema.json
# yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultlocale.1.10.0.schema.json
PackageIdentifier: microsoft.msixsdk
PackageVersion: 1.7.32
PackageLocale: en-US