Skip to content

agentHost: Suppress hidden session summary updates - #331117

Merged
Benjamin Christopher Simmonds (benibenj) merged 1 commit into
mainfrom
benibenj/agents/external-session-hidden-summary-feedback
Aug 16, 2026
Merged

agentHost: Suppress hidden session summary updates#331117
Benjamin Christopher Simmonds (benibenj) merged 1 commit into
mainfrom
benibenj/agents/external-session-hidden-summary-feedback

Conversation

@benibenj

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #331115 addressing post-merge review feedback:

  • suppress root/sessionSummaryChanged for restored sessions that have not been published
  • continue advancing the retained summary baseline while the session is hidden
  • publish the current complete summary when visibility is enabled, then resume normal deltas
  • add regression coverage for hidden updates and later publication

Testing

  • npm run typecheck-client
  • targeted AgentHostStateManager tests
  • ESLint and changed-file hygiene

Keep summary baselines current for unpublished restored sessions without broadcasting root deltas. When the session is later published, clients receive the latest complete summary before normal incremental updates resume.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Suppresses summary-change notifications for hidden restored Agent Host sessions while preserving current state for later publication.

Changes:

  • Gates summary notifications on publication state.
  • Adds regression coverage for hidden updates and later visibility.
  • Documents hidden-session baseline behavior.
Show a summary per file
File Description
agentHostStateManager.ts Suppresses updates for unpublished summaries.
agentHostStateManager.test.ts Tests hidden and subsequent visible updates.
AGENT_HOST_SESSIONS_PROVIDER.md Documents the behavior.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Balanced

changes,
}),
(session, changes) => {
if (this._publishedSessionSummaries.has(session)) {
@benibenj
Benjamin Christopher Simmonds (benibenj) merged commit 7d98117 into main Aug 16, 2026
28 checks passed
@benibenj
Benjamin Christopher Simmonds (benibenj) deleted the benibenj/agents/external-session-hidden-summary-feedback branch August 16, 2026 20:52
@vs-code-engineering vs-code-engineering Bot added this to the 1.134.0 milestone Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants