Make rename chat tool non-blocking - #331114
Draft
roblourens wants to merge 2 commits into
Draft
Conversation
Run chat renames in an ordered background queue and report failures after the tool returns.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Makes rename_chat non-blocking while preserving rename order and surfacing background failures.
Changes:
- Queues asynchronous renames with
Sequencer. - Logs failures and updates tool messaging.
- Adds coverage for immediate return, ordering, forwarding, and failures.
Show a summary per file
| File | Description |
|---|---|
sessionServerTools.ts |
Implements queued background renames and updated messaging. |
agentService.ts |
Reports background rename failures through logging. |
sessionServerTools.test.ts |
Tests asynchronous rename behavior and sequencing. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
Wait for background rename work before asserting persisted state and treat persistence failures as asynchronous.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rename_chatimmediately while applying the rename in the backgroundValidation
npm run transpile-client./scripts/test.sh --run src/vs/platform/agentHost/test/node/sessionServerTools.test.ts(42 passing)npm run typecheck-client(change is clean; command still reports unrelated existing errors incopilotAgentSession.test.ts,copilotToolDisplay.test.ts, andassignmentService.ts)(Written by Copilot)