Add ECC bundles and address code scanning alert - #331046
Open
Barki Mustapha (devops2626) wants to merge 16 commits into
Open
Add ECC bundles and address code scanning alert#331046Barki Mustapha (devops2626) wants to merge 16 commits into
Barki Mustapha (devops2626) wants to merge 16 commits into
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Potential fix for code scanning alert no. 11: Uncontrolled command line
…scode-instincts.yaml)
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Dmitriy Vasyura (@dmitrivMS)Matched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR introduces repository-local Codex/Claude “ECC tools” configuration and agent scaffolding, and hardens the Windows installer path handling used by the sanity test context.
Changes:
- Add
.codexmulti-agent configuration (reviewer/explorer/docs) and MCP baseline config. - Add repo “skills/identity/instincts” artifacts under
.agentsand.claudefor tool-assisted workflows. - Add validation and normalization around Windows installer path usage in
TestContext.installWindowsApp.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test/sanity/src/context.ts | Adds input validation and logging improvements for the Windows installer path used in sanity tests. |
| .codex/config.toml | Adds Codex CLI baseline config, MCP servers, and multi-agent settings. |
| .codex/agents/reviewer.toml | Defines reviewer agent model/settings and instructions. |
| .codex/agents/explorer.toml | Defines explorer agent model/settings and instructions. |
| .codex/agents/docs-researcher.toml | Defines docs researcher agent model/settings and instructions. |
| .codex/AGENTS.md | Documents the repo-local Codex/ECC baseline and agent roles. |
| .claude/skills/vscode/SKILL.md | Adds generated “repo conventions” skill content for Claude. |
| .claude/identity.json | Adds generated identity/style preferences configuration for Claude. |
| .claude/homunculus/instincts/inherited/vscode-instincts.yaml | Adds generated “instincts” rules derived from repo analysis. |
| .claude/ecc-tools.json | Adds ECC tools generation metadata and managed-file manifest. |
| .agents/skills/vscode/agents/openai.yaml | Adds skill metadata for the Codex/OpenAI agent interface. |
| .agents/skills/vscode/SKILL.md | Adds generated “repo conventions” skill content for Codex-facing agents. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+10
to
+29
| args = ["-y", "@modelcontextprotocol/server-github"] | ||
|
|
||
| [mcp_servers.context7] | ||
| command = "npx" | ||
| args = ["-y", "@upstash/context7-mcp@latest"] | ||
|
|
||
| [mcp_servers.exa] | ||
| url = "https://mcp.exa.ai/mcp" | ||
|
|
||
| [mcp_servers.memory] | ||
| command = "npx" | ||
| args = ["-y", "@modelcontextprotocol/server-memory"] | ||
|
|
||
| [mcp_servers.playwright] | ||
| command = "npx" | ||
| args = ["-y", "@playwright/mcp@latest", "--extension"] | ||
|
|
||
| [mcp_servers.sequential-thinking] | ||
| command = "npx" | ||
| args = ["-y", "@modelcontextprotocol/server-sequential-thinking"] |
|
|
||
| [mcp_servers.playwright] | ||
| command = "npx" | ||
| args = ["-y", "@playwright/mcp@latest", "--extension"] |
| # ECC Tools generated Codex baseline | ||
| approval_policy = "on-request" | ||
| sandbox_mode = "workspace-write" | ||
| web_search = "live" |
|
|
||
| ## Commit Conventions | ||
|
|
||
| Follow these commit message conventions based on 1 analyzed commits. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces repository-local Codex and Claude "ECC tools" configuration alongside multi-agent scaffolding. It also hardens path handling for the Windows installer within sanity tests.
Key Changes: