agentHost: complete skills after whitespace#320721
Merged
DonJayamanne merged 1 commit intoJun 10, 2026
Merged
Conversation
Support skill slash completions when the token appears after whitespace in a user message while keeping slash commands leading-only. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Enables Agent Host skill slash-completions when the / token is typed after whitespace inside a user message, while keeping slash-command completion logic leading-only (by continuing to use extractLeadingSlashToken in command providers).
Changes:
- Add
extractWhitespaceDelimitedSlashTokento extract the current whitespace-delimited/...token at the cursor. - Switch
AgentHostSkillCompletionProviderto use the new extractor so skills can complete mid-message. - Extend unit tests to cover in-message token replacement, whitespace-delimited behavior, and negative cases.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/agentHost/test/node/agentHostSkillCompletionProvider.test.ts | Adds test coverage for mid-message skill completion and correct replacement ranges. |
| src/vs/platform/agentHost/node/agentHostSlashCompletion.ts | Introduces a whitespace-delimited slash-token extractor shared by completion providers. |
| src/vs/platform/agentHost/node/agentHostSkillCompletionProvider.ts | Updates skill completion extraction to support slash tokens after whitespace. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 2
dmitrivMS
approved these changes
Jun 10, 2026
DonJayamanne
deleted the
agents/today-in-skill-completion-provider-for-agent-hos-9e247e0d
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support skill slash completions when the token appears after whitespace in a user message while keeping slash commands leading-only.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com