Avoid hardcoding external ingest embedding type#308873
Merged
mjbvz merged 2 commits intomicrosoft:mainfrom Apr 9, 2026
Merged
Conversation
Also updated some telemetry fields so we can do correlations more easily
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Copilot workspace chunk search’s external ingest path to avoid hardcoding the embedding model when interpreting search results, and enriches telemetry so searches can be correlated across call sites.
Changes:
ExternalIngestIndex.searchnow derives theEmbeddingTypefrom the service’sembedding_modelresponse field instead of using a fixed constant.ExternalIngestIndex.searchnow accepts aTelemetryCorrelationIdand logs additional correlation properties in success/cancel/error telemetry.- Call site updated to pass the richer telemetry object through (
CodeSearchChunkSearch→ExternalIngestIndex).
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/platform/workspaceChunkSearch/node/codeSearch/externalIngestIndex.ts | Use response-provided embedding model for result metadata; switch search telemetry input to TelemetryCorrelationId and emit additional correlation fields. |
| extensions/copilot/src/platform/workspaceChunkSearch/node/codeSearch/codeSearchChunkSearch.ts | Pass TelemetryCorrelationId through to ExternalIngestIndex.search. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 2
extensions/copilot/src/platform/workspaceChunkSearch/node/codeSearch/externalIngestIndex.ts
Outdated
Show resolved
Hide resolved
extensions/copilot/src/platform/workspaceChunkSearch/node/codeSearch/externalIngestIndex.ts
Show resolved
Hide resolved
…Search/externalIngestIndex.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
roblourens
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updated some telemetry fields so we can do correlations more easily