Skip to content

Show combination tool approval args#308747

Merged
alexr00 merged 10 commits intomainfrom
alexr00/honest-ferret
Apr 10, 2026
Merged

Show combination tool approval args#308747
alexr00 merged 10 commits intomainfrom
alexr00/honest-ferret

Conversation

@alexr00
Copy link
Copy Markdown
Member

@alexr00 alexr00 commented Apr 9, 2026

Fixes #306264

Copilot AI review requested due to automatic review settings April 9, 2026 10:37
@alexr00 alexr00 enabled auto-merge (squash) April 9, 2026 10:37
@alexr00 alexr00 self-assigned this Apr 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

Screenshot Changes

Base: f8360758 Current: 26124b7e

Changed (1)

agentSessionsViewer/ApprovalRowLongLabel/Dark
Before After
before after

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses tool approval management UX by allowing combination-level approvals to carry a displayable arguments string, so users can distinguish and manage specific “tool + args” approvals (e.g., different extension.open invocations).

Changes:

  • Changes the proposed approveCombination shape to include a { message, arguments? } object so tools can provide a user-visible argument summary.
  • Persists the combination “arguments” string alongside the combination approval key and surfaces it in the Manage Tool Approvals quick tree via a “View Arguments” button/dialog.
  • Updates Copilot’s VS Code command tool to populate the new approveCombination.arguments field and display args in the confirmation message.
Show a summary per file
File Description
src/vscode-dts/vscode.proposed.toolInvocationApproveCombination.d.ts Updates proposed API type/docs for combination approval metadata (message + arguments).
src/vs/workbench/contrib/chat/common/tools/languageModelToolsService.ts Extends internal tool confirmation message shape to carry arguments for combinations.
src/vs/workbench/contrib/chat/common/tools/languageModelToolsConfirmationService.ts Extends confirmation ref/combination type to include arguments.
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatToolConfirmationSubPart.ts Passes combination arguments through UI confirmation subpart plumbing.
src/vs/workbench/contrib/chat/browser/tools/languageModelToolsConfirmationService.ts Stores/loads combination args; adds “View Arguments” UI affordance and dialog.
src/vs/workbench/api/common/extHostLanguageModelTools.ts Converts new proposed API shape into internal { label, key, arguments } confirmation data.
extensions/copilot/src/extension/vscode.proposed.toolInvocationApproveCombination.d.ts Mirrors the proposed API change in the Copilot extension’s proposal typings.
extensions/copilot/src/extension/tools/node/vscodeCmdTool.tsx Populates and displays command arguments; emits new approveCombination object.
.github/instructions/api-version.instructions.md Updates contributor guidance around proposed API versioning/back-compat.

Copilot's findings

  • Files reviewed: 7/9 changed files
  • Comments generated: 4

lszomoru
lszomoru previously approved these changes Apr 9, 2026
lszomoru
lszomoru previously approved these changes Apr 9, 2026
@alexr00 alexr00 marked this pull request as draft April 10, 2026 08:25
auto-merge was automatically disabled April 10, 2026 08:25

Pull request was converted to draft

@alexr00 alexr00 marked this pull request as ready for review April 10, 2026 09:11
@alexr00 alexr00 merged commit 8b5518b into main Apr 10, 2026
27 checks passed
@alexr00 alexr00 deleted the alexr00/honest-ferret branch April 10, 2026 10:05
@vs-code-engineering vs-code-engineering bot added this to the 1.116.0 milestone Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tool approval management is not showing arguments for commands

4 participants