base: add bounds check in getGridNode for invalid location index#308741
Open
Akash504-ai wants to merge 1 commit intomicrosoft:mainfrom
Open
base: add bounds check in getGridNode for invalid location index#308741Akash504-ai wants to merge 1 commit intomicrosoft:mainfrom
Akash504-ai wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @joaomorenoMatched files:
@benibenjMatched files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Adds a defensive bounds check when traversing grid nodes.
Previously,
getGridNodeassumed that the provided location index is always valid. This change guards against invalid indices, preventing potential runtime errors when accessingnode.children[index]. This does not change existing behavior but improves robustness.