Skip to content

Conversation

@mizdra
Copy link
Contributor

@mizdra mizdra commented Dec 30, 2025

close: #285400

$ export XDG_DATA_HOME="/Users/mizdra/.local/share"; ./scripts/test.sh --run 'vs/workbench/contrib/terminalContrib/history/test/common/history.test.js' --grep fetchFishHistory

> [email protected] electron
> node build/lib/electron.ts

Found --crash-reporter-directory argument. Setting crashDumps directory to be '/Users/mizdra/src/github.com/microsoft/vscode/.build/crashes'
[29260:1230/171826.353523:INFO:CONSOLE:2] "The vm module of Node.js is unsupported in Electron's renderer process due to incompatibilities with the Blink rendering engine. Crashes are likely and avoiding the module is highly recommended. This module may be removed in a future release.", source: node:electron/js2c/renderer_init (2)
[29260:1230/171826.488522:INFO:CONSOLE:2] "Platform browser has already been set. Overwriting the platform with [object Object].", source: /Users/mizdra/src/github.com/microsoft/vscode/node_modules/@vscode/vscode-languagedetection/dist/lib/index.js (2)
(node:29265) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `Code - OSS Helper (Renderer) --trace-deprecation ...` to show where the warning was created)
(node:29265) [DEP0025] DeprecationWarning: sys is deprecated. Use util instead.
(node:29265) ExperimentalWarning: WASI is an experimental feature and might change at any time


  Terminal history
    fetchFishHistory
      local
        ✔ current OS
      local (overriden path)
        ✔ current OS
      remote
        ✔ Windows
        ✔ macOS
        ✔ Linux
      remote (overriden path)
        ✔ Windows
        ✔ macOS
        ✔ Linux
      sanitizeFishHistoryCmd
        ✔ valid new-lines
        ✔ invalid new-lines


  10 passing (6ms)

@mizdra
Copy link
Contributor Author

mizdra commented Dec 30, 2025

@microsoft-github-policy-service agree

Copilot AI review requested due to automatic review settings January 3, 2026 15:36
@Tyriar Tyriar enabled auto-merge January 3, 2026 15:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes test failures that occurred when the XDG_DATA_HOME environment variable is set on the system. The tests were previously only handling the HOME environment variable but not XDG_DATA_HOME, which affected the Fish shell history path resolution in certain environments.

Key Changes:

  • Updated test setup/teardown to preserve and restore XDG_DATA_HOME environment variable
  • Added explicit deletion of XDG_DATA_HOME in test setup to ensure clean test state

@Tyriar Tyriar merged commit 2bd1975 into microsoft:main Jan 4, 2026
22 of 23 checks passed
@mizdra mizdra deleted the fix-failed-test branch January 5, 2026 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests fails in environments where XDG_DATA_HOME is set

4 participants