Skip to content

Conversation

@jakebailey
Copy link
Member

See microsoft/TypeScript#62876

module has been frowned on for a very long time, was soft deprecated a few releases ago, hard errors in 6.0, and won't even parse in 7.0.

Copilot AI review requested due to automatic review settings December 11, 2025 20:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the codebase by replacing deprecated TypeScript module declarations with the modern namespace keyword. This change is necessary for compatibility with TypeScript 6.0+ which hard errors on the old module syntax, and TypeScript 7.0 which won't parse it at all.

  • Replaces all instances of export module with export namespace
  • Replaces all instances of declare module with declare namespace
  • Maintains identical functionality with updated syntax

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/vs/workbench/contrib/tasks/common/problemMatcher.ts Updates three exported namespace declarations (FileLocationKind, ProblemLocationKind, ApplyToKind)
src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts Updates globalThis ambient declaration
src/vs/workbench/contrib/debug/common/debugProtocol.d.ts Updates DebugProtocol ambient declaration in auto-generated file
src/vs/server/node/remoteExtensionHostAgentServer.ts Updates vsda native module ambient declaration
src/vs/platform/sign/node/signService.ts Updates vsda native module ambient declaration
src/vs/platform/sign/browser/signService.ts Updates vsdaWeb module ambient declaration
src/vs/platform/extensionManagement/node/extensionSignatureVerificationService.ts Updates vsceSign module ambient declaration
src/vs/editor/standalone/browser/standaloneServices.ts Updates StandaloneServices exported namespace

All changes are straightforward syntactic replacements with no functional impact. The changes are correct and necessary for TypeScript compatibility.

@jakebailey
Copy link
Member Author

cc @mjbvz

@mjbvz
Copy link
Collaborator

mjbvz commented Dec 11, 2025

Thanks!

@mjbvz mjbvz enabled auto-merge December 11, 2025 21:08
@vs-code-engineering vs-code-engineering bot added this to the December / January 2026 milestone Dec 11, 2025
@mjbvz mjbvz merged commit a210fd3 into microsoft:main Dec 11, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants