Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix single terminal actions not working after changing its color #234204

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −2
Open

Fix single terminal actions not working after changing its color #234204

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74fee6c
Fixes #233761
itsmevichu Nov 19, 2024
6b60913
Merge branch 'microsoft:main' into change-color-breaks-inline-ternmin…
itsmevichu Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/vs/workbench/contrib/terminal/browser/terminalActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1466,8 +1466,7 @@ function getSelectedInstances(accessor: ServicesAccessor, args?: unknown, args2?
const list = listService.lastFocusedList;
// Get selected tab list instance(s)
const selections = list?.getSelection();
// Get inline tab instance if there are not tab list selections #196578
if (terminalGroupService.lastAccessedMenu === 'inline-tab' && !selections?.length) {
if (terminalGroupService.lastAccessedMenu === 'inline-tab') {
const instance = terminalGroupService.activeInstance;
return instance ? [terminalGroupService.activeInstance] : undefined;
}
Expand Down