TS extension: register call to CopilotRelated with copilot extension #228610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
registerRelatedFilesProvider is a new method on the copilot extension. CopilotRelated is a new tsserver command that provides information from tsserver to copilot. (The information is not necessarily copilot-specific, of course.)
Thanksyou23
reviewed
Sep 14, 2024
mjbvz
reviewed
Sep 16, 2024
| @@ -150,6 +151,60 @@ export default class TypeScriptServiceClientHost extends Disposable { | |||
| standardFileExtensions: [], | |||
| }, onCompletionAccepted); | |||
| } | |||
| // TODO: Still probably isn't the right place for this | |||
There was a problem hiding this comment.
Can this be registered as a language feature? That way it only gets activated when our other language features activate
| // TODO: Still probably isn't the right place for this | ||
| const ext = vscode.extensions.getExtension('github.copilot'); | ||
| if (!ext) { | ||
| vscode.window.showErrorMessage(vscode.l10n.t('Could not find related-files extension')); |
There was a problem hiding this comment.
Expected so should not show a user error
| } | ||
| // TODO: This compiles but will never cancel; this needs a token that somebody might actually cancel. | ||
| const cancel = new vscode.CancellationTokenSource(); | ||
| const response = await this.client.execute('copilotRelated', { file, }, cancel.token); |
There was a problem hiding this comment.
We should have nulToken that you can use for this
| if (response.type !== 'response' || !response.body) { | ||
| return []; | ||
| } | ||
| return response.body.map(vscode.Uri.file); |
There was a problem hiding this comment.
I think you want client.toResource instead. That will handle non file: uris
| callback: (uri: vscode.Uri) => Promise<{ entries: vscode.Uri[]; traits?: { name: string; value: string }[] }> | ||
| ): void; | ||
| } | undefined; | ||
| if (relatedAPI) { |
There was a problem hiding this comment.
Does this also need to be gated on the TS server version?
| extensionId: 'vscode.typescript-language-features', | ||
| languageId | ||
| }; | ||
| relatedAPI.registerRelatedFilesProvider(id, async uri => { |
There was a problem hiding this comment.
Does copilot pass a cancellation token? If not, we should request that it does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
registerRelatedFilesProvider is a new method on the copilot extension. CopilotRelated is a new tsserver command that provides information from tsserver to copilot. (The information is not necessarily copilot-specific, of course.)
This code is quite far from done:
However, I want to make it available so I can get comments on it.