easier to use show options, notebook repl editor helper #228577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amunger
commented
Sep 13, 2024
| if (this.viewModel === undefined || !this.viewModel.equal(textModel)) { | ||
| const oldBottomToolbarDimensions = this._notebookOptions.computeBottomToolbarDimensions(this.viewModel?.viewType); | ||
| this._detachModel(); | ||
| await this._attachModel(textModel, viewState, perf); | ||
| await this._attachModel(textModel, viewType ?? textModel.viewType, viewState, perf); |
There was a problem hiding this comment.
more separation between the textModel's viewtype (more like notebook type) and the viewmodels viewtype - the notebook type is used by default, but a different viewtype could be set.
The only other usage of the viewmodel.viewtype was for determining the placement of the cell toolbar which can be configured by viewtype, and should therefore probably be independent from the notebook type
rebornix
approved these changes
Sep 13, 2024
songjianet
approved these changes
Sep 15, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#154983