Ensure cells in a readonly notebook cannot be edited #228309
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Sep 12, 2024
| @@ -107,6 +107,7 @@ export interface NotebookOptionsChangeEvent { | |||
| readonly outputScrolling?: boolean; | |||
| readonly outputLinkifyFilePaths?: boolean; | |||
| readonly minimalError?: boolean; | |||
| readonly readonly?: boolean; | |||
There was a problem hiding this comment.
@rebornix This seems to be the right fix, however
there are issues related to this and my plan was to look into them in debt,
Here's a similar issue #185320
Very likely related, I'd prefer to get this merged in debt, to avoid taking this in the last minute (last minute for me),
Else if something goes wrong with this, then we end up with readonly notebooks which is a very bad bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuxes #228302