Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add accessible view for comment thread widget #228018

Merged
merged 19 commits into from
Sep 17, 2024
Merged

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Sep 9, 2024

fixes #226091

@meganrogge meganrogge marked this pull request as draft September 9, 2024 18:34
@meganrogge meganrogge self-assigned this Sep 9, 2024
@meganrogge meganrogge added this to the September 2024 milestone Sep 9, 2024
@meganrogge meganrogge marked this pull request as ready for review September 10, 2024 20:03
@meganrogge
Copy link
Contributor Author

@alexr00 I went down the rabbit hole trying to get the actions to work, but realized that once we have the ability to focus the comment that was focused in the accessible view on hide, that shouldn't be necessary.

Additionally, the actions in the comment thread toolbar are more conducive to be handled there vs the accessible view - such as reaction or edit comment (the accessible view is readonly by design).

@meganrogge meganrogge enabled auto-merge (squash) September 16, 2024 17:35
@alexr00 alexr00 self-requested a review September 16, 2024 18:57
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meganrogge, I've enabled focusing on a specific comment with #228770. Just like before you need to call revealCommentThread and with this change the comment you pass in will get focus.

export function revealCommentThread(commentService: ICommentService, editorService: IEditorService, uriIdentityService: IUriIdentityService,

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meganrogge, I know you want to get this merged and I didn't want to give you the run around by asking for more changes. I don't think setActiveCommentThread or the comments service is the best place to keep track of the "active comment for the accessible view", which is different from the "active comment which was last focused which we maintain for the purposes of extension API". I'd prefer to track "active comment for the accessible view" in the accessible view provider and remove this knowledge from the comment service, especially since this information doesn't seem to need to persist after the accessible view is closed. I've created a PR with these changes to merge into your own PR branch: #228866

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@meganrogge meganrogge merged commit 15183fc into main Sep 17, 2024
7 checks passed
@meganrogge meganrogge deleted the merogge/comment-thread-view branch September 17, 2024 19:09
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support accessible view in comment widget thread
3 participants