Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support accessible view in comment widget thread #226091

Closed
jooyoungseo opened this issue Aug 20, 2024 · 3 comments · Fixed by #228018
Closed

Support accessible view in comment widget thread #226091

jooyoungseo opened this issue Aug 20, 2024 · 3 comments · Fixed by #228018
Assignees
@meganrogge
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues comments Comments Provider/Widget/Panel issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders
Milestone
September 2024

Comments

@jooyoungseo
Copy link

jooyoungseo commented Aug 20, 2024 •
edited
Loading

Type: Bug

CC @meganrogge

Repros

  1. Open any file containing comment thread

  2. Press alt+F9 to go to the next comment

  3. After alt+F9 is pressed, the comment content is read aloud to screen reader; however, see if you can open the spoken content in the Accessible View (alt+F2)

Current Issue

Accessible View is not supported in the alt+F9 comment tooltip

Expected Behavior

alt+F2 should be supported in this context just like other tooltips.

VS Code version: Code - Insiders 1.93.0-insider (e2b5430, 2024-08-20T08:04:15.567Z)
OS version: Windows_NT x64 10.0.22631
Modes:

System Info
Item Value
CPUs 11th Gen Intel(R) Core(TM) i5-1145G7 @ 2.60GHz (8 x 2611)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
webnn: disabled_off
Load (avg) undefined
Memory (System) 15.71GB (6.55GB free)
Process Argv --crash-reporter-id b05b88e5-8894-4031-ae34-fa034ebddea9
Screen Reader yes
VM 0%
Extensions (128)
Extension Author (truncated) Version
vscode-openapi 42C 4.28.1
zotenote A-W 1.0.1
android-dev-ext ade 1.4.0
aiprm-lang AIP 0.0.2
Bookmarks ale 13.5.0
openscad Ant 1.2.2
spellright ban 3.0.136
zoterolatex bna 0.4.1
mermaid-markdown-syntax-highlighting bpr 1.6.0
external-pdf cha 1.2.0
doxdocgen csc 1.4.0
vscode-markdownlint Dav 0.53.0
vscode-eslint dba 3.0.10
vscode-quick-select dba 0.2.9
vscode-deno den 3.38.2
gitlens eam 14.6.1
EditorConfig Edi 0.16.4
prettier-vscode esb 10.1.0
figma-vscode-extension fig 0.3.5
vscode-firefox-debug fir 2.9.10
shell-format fox 7.2.5
vscode-google-translate fun 1.4.13
codespaces Git 1.17.2
copilot Git 1.223.1058
copilot-chat Git 0.20.2024082001
remotehub Git 0.62.0
vscode-github-actions git 0.26.2
vscode-pull-request-github Git 0.95.2024082004
cloudcode goo 2.16.4
overleaf-workshop iam 0.13.2
cslpreview igo 0.2.2
path-autocomplete ion 1.25.0
latex-workshop Jam 10.1.0
lilypond-syntax jea 0.1.1
scheme jea 0.2.0
better-cpp-syntax jef 1.17.2
commitlint jos 2.6.0
language-julia jul 1.109.1
google-search kam 0.0.1
vscode-lua-format Koi 1.3.8
lilypond-formatter lhl 0.2.3
lilypond-pdf-preview lhl 0.2.8
lilypond-snippets lhl 0.1.1
vslilypond lhl 1.7.3
language-matlab Mat 1.2.5
zotero mbl 0.1.11
git-graph mhu 1.30.0
azure-dev ms- 0.8.3
vscode-azureappservice ms- 0.25.2
vscode-azurecontainerapps ms- 0.6.1
vscode-azurefunctions ms- 1.15.2
vscode-azureresourcegroups ms- 0.8.3
vscode-azurestaticwebapps ms- 0.12.2
vscode-azurestorage ms- 0.16.0
vscode-azurevirtualmachines ms- 0.6.5
vscode-cosmosdb ms- 0.22.0
vscode-docker ms- 1.29.2
vscode-edge-devtools ms- 2.1.5
black-formatter ms- 2024.3.12071014
debugpy ms- 2024.11.2024081401
flake8 ms- 2023.13.12291011
isort ms- 2023.13.12321012
python ms- 2024.13.2024082001
vscode-pylance ms- 2024.8.101
jupyter ms- 2024.8.2024081201
jupyter-keymap ms- 1.1.2
jupyter-renderers ms- 1.0.19
vscode-jupyter-cell-tags ms- 0.1.8
vscode-jupyter-slideshow ms- 0.1.5
remote-containers ms- 0.381.0
remote-ssh ms- 0.114.2024081215
remote-ssh-edit ms- 0.86.0
remote-wsl ms- 0.81.8
vscode-remote-extensionpack ms- 0.25.0
azure-account ms- 0.12.0
azure-repos ms- 0.38.0
cmake-tools ms- 1.18.44
cpptools ms- 1.21.6
cpptools-extension-pack ms- 1.3.0
js-debug-nightly ms- 2024.8.1517
powershell ms- 2024.3.2
remote-explorer ms- 0.5.2024011009
remote-repositories ms- 0.40.0
remote-server ms- 1.6.2024011109
vscode-github-issue-notebooks ms- 0.0.130
vscode-node-azure-pack ms- 1.2.0
vscode-selfhost-test-provider ms- 0.3.25
vscode-serial-monitor ms- 0.12.0
vscode-speech ms- 0.10.0
vscode-speech-language-pack-en-ca ms- 0.4.0
vscode-speech-language-pack-en-gb ms- 0.4.0
vscode-speech-language-pack-ko-kr ms- 0.4.0
vsliveshare ms- 1.0.5936
windows-ai-studio ms- 0.4.0
autodocstring njp 0.6.1
pandocciter not 0.10.4
publisher pos 1.1.5
shiny Pos 1.0.0
shinyuieditor pos 0.5.0
quarto qua 1.114.0
r-debugger RDe 0.5.4
java red 1.33.0
vscode-xml red 0.27.1
vscode-yaml red 1.14.0
r REd 2.8.4
multi-command ryu 1.6.0
AudioQ Seh 0.0.2
vscode-deepl soe 1.1.1
abc-music sof 0.4.0
lua sum 3.10.5
latex-utilities tec 0.4.14
cmake twx 0.0.17
vscode-terminal-here Tyr 0.2.4
windows-terminal Tyr 0.7.0
errorlens use 3.16.0
intellicode-api-usage-examples Vis 0.2.8
vscodeintellicode Vis 1.2.30
vscode-conventional-commits viv 1.25.0
vscode-arduino vsc 0.7.0
vscode-gradle vsc 3.16.4
vscode-java-debug vsc 0.58.0
vscode-java-dependency vsc 0.24.0
vscode-java-pack vsc 0.29.0
vscode-java-test vsc 0.42.0
vscode-maven vsc 0.44.0
zotero-cite XIN 0.8.6
markdown-all-in-one yzh 3.6.2
grammarly znc 0.25.0

(1 theme extensions excluded)

A/B Experiments 
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805cf:30301675
vsaa593:30376534
py29gd2263:31024238
c4g48928:30535728
a9j8j154:30646983
962ge761:30841072
pythongtdpath:30726887
welcomedialog:30812478
pythonnoceb:30776497
asynctok:30898717
dsvsc014:30777825
dsvsc015:30821418
pythonregdiag2:30926734
pythonmypyd1:30859725
h48ei257:31000450
pythontbext0:30879054
accentitlementst:30870582
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
cppperfnew:30980852
pythonait:30973460
01bff139:31013167
a69g1124:31018687
dvdeprecation:31040973
dwnewjupyter:31046869
impr_priority:31057980
nativerepl1:31104042
refactort:31084545
pythonrstrctxt:31093868
flighttreat:31119334
wkspc-onlycs-c:31111717
nativeloc1:31118317
wkspc-ranged-c:31118571
cf971741:31111988
jh802675:31111929
e80f6927:31120813
@jooyoungseo jooyoungseo changed the title [Accessibility] Accessible View (alt+F2) is not supported in the comment tooltip [Accessibility] Accessible View (alt+F2) is not supported in the alt+F9 comment tooltip Aug 20, 2024
@meganrogge meganrogge added comments Comments Provider/Widget/Panel issues accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality labels Aug 21, 2024
@meganrogge meganrogge added this to the September 2024 milestone Aug 21, 2024
@meganrogge meganrogge assigned alexr00 and unassigned alexr00 Aug 21, 2024
@meganrogge meganrogge changed the title [Accessibility] Accessible View (alt+F2) is not supported in the alt+F9 comment tooltip Support accessible view in comment widget thread Aug 26, 2024
@meganrogge meganrogge mentioned this issue Sep 9, 2024
Merged
@alexr00
Copy link
Member

alexr00 commented Sep 12, 2024 •
edited
Loading

@meganrogge I'm looking through your PR now, and I'm wondering whether it's possible to just make the comment widget itself sufficiently accessible without having to add an accessible view to it. Do you think this is possible? What would we need to do to accomplish this?

@meganrogge
Copy link
Contributor

We'd need to support arrow key navigation of content char by char, so I don't think that is possible.

@alexr00
Copy link
Member

alexr00 commented Sep 13, 2024

Got it, thank you for explaining!

alexr00 added a commit that referenced this issue Sep 16, 2024
@alexr00
Allow specific comments to be focused on
fbdffe7 
Part of #226091
@alexr00 alexr00 mentioned this issue Sep 16, 2024
Merged
alexr00 added a commit that referenced this issue Sep 16, 2024
@alexr00
Allow specific comments to be focused on (#228770)
dc8e741 
Part of #226091
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 17, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meganrogge meganrogge

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues comments Comments Provider/Widget/Panel issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
September 2024
Development

Successfully merging a pull request may close this issue.

add accessible view for comment thread widget microsoft/vscode
3 participants
@jooyoungseo @meganrogge @alexr00