do not use shell integration for Python subshell if Python setting is disabled #24418
+102
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonykim1
added
bug
|
separated this out from #24416 (comment) |
karthiknadig
approved these changes
Nov 12, 2024
anthonykim1
added a commit
that referenced
this pull request
Dec 4, 2024
Related: #24418 Further resolves: #24422 Shell integration does not exist on windows python repl so dont use execute command on python subshell in this case. This will prevent keyboard interrupt from happening even when setting for shell integration is enabled for python shell (which is currently only supported on mac and linux)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #24422
This PR will resolve KeyboardInterrupt from happening when shell integration is enabled on upstream shell but not on the sub-shell (Python)
If the user has explicitly set their Python shell integration setting to false,
then do not use shell integration inside the sub-shell (Python Terminal REPL in this case),
regardless of upper shell integration status (Terminal shell integration setting in vscode).
We should still be safe from manual installation of shell integration with the setting disabled(https://code.visualstudio.com/docs/terminal/shell-integration#_manual-installation)
since we are still reading the value of terminal.shellIntegration, and looking at Python's shell integration setting first to begin with.