Try shell integration proposed API for Python extension #23769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonykim1
added
area-terminal
area-environments
anthonykim1
changed the title
Co-authored-by: Daniel Imms <[email protected]>
|
Related: microsoft/vscode#221405 and microsoft/vscode#221399 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
Reference: #23738
As of Jul 9th: struggling to get exit code beside undefined. Was able to get exit code of 0 for once, and continuing to get undefined. Starting out with lightweight test where I would basically create terminal, send dummy command "echo hello world" and trying to observe the exit code of this.
TODO: Later should be creating hidden terminal that will print out user's environment variable living under their shell specific initialization scripts.
TODO: Also figure out observing whether terminal REPL successfully by using shell integration proposed API instead of terminal data write event.
TODO: Also figure out which additional activation commands we need to test out for Python extension.