Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open issue report for web #23424

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

open issue report for web #23424

wants to merge 3 commits into from

Conversation

justschen
Copy link

@justschen justschen commented May 14, 2024

related: microsoft/vscode#203247 for web issue reporter! allows extension to contribute the command on web

@paulacamargo25 paulacamargo25 added feature-request Request for new features or functionality skip tests Updates to tests unnecessary labels May 14, 2024
@justschen justschen marked this pull request as ready for review May 14, 2024 23:25
@VSCodeTriageBot VSCodeTriageBot added this to the May 2024 milestone May 14, 2024
@karthiknadig
Copy link
Member

@justschen You can't re-use the ReportIssueCommandHandler command handler from main extension in the browser version. You will have to implement that bit subtracting all the items that the main one depends on. We may need to refactor that to make it work.

Basically it is not compiling to browser version because of all the dependencies that cannot run in the browser version.

@paulacamargo25 Can you help Justin with this? The ReportIssueCommandHandler depends on lots of interfaces that it cannot be directly used in the browser version. Can you simplify it in a way that only directly consumes VS Code APIs and not use inversify?

@justschen justschen marked this pull request as draft May 15, 2024 00:49
@karthiknadig karthiknadig modified the milestones: May 2024, June 2024 May 27, 2024
@karthiknadig karthiknadig modified the milestones: June 2024, July 2024 Jun 24, 2024
@karthiknadig karthiknadig modified the milestones: July 2024, August 2024 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants