Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PyPI checker and issue creator #22807
Add PyPI checker and issue creator #22807
Changes from all commits
77a5c27
3f25b72
e0eb242
e29d80b
6e518ab
dd49237
b368b6c
36aeb6b
3cc92d7
ab3291f
95dc6f7
37205b1
bb82ac9
116d075
0b81409
70e66ec
ddd54d4
9e6295d
9b3f792
d98f24f
0e0163c
14a48c6
14e7069
c2a08c4
b947a5d
ee433f4
5c0f0a1
c5763f8
568c1b1
e20d903
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is
pytest
imported here? it won't even be installed when this script is actually called.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we would need this for
importlib.metadata.version("pytest")
to correctly fetch the version of pytest that is imported.Should I add pytest in additional to
python -m pip install -U pip wheel PyGithub
or do we not need it at all??There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In your pipeline you are not installing pytest.
import pytest
will immediately fail. This works for you locally because you have pytest installed locally. Try running this from a fresh environment.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you need
pytest
then you need to install all requirements before running this script. In this script you can later update the installed pytest to whatever version you want.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see... the intent of importing pytest and running
importlib.metadata.version("pytest")
was to get the version of pytest that our python extension was using...Now I'm little lost on how to correctly get this value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I install test-requirement.txt and then use importlib to dynaimically get it since test-requirement.txt does not pin to specific version of pytest.