Skip to content

Try to get around .npmrc not being overridden #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bschnurr wants to merge 1 commit into from
+4 −22
Closed

Try to get around .npmrc not being overridden #932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions build/templates/publish-extension.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,6 @@ jobs:
type: releaseJob # This makes a job a release job
isProduction: true # Indicates a production release
steps:
- template: setup.yml
parameters:
installNode: true
installPython: false

- task: 1ES.DownloadPipelineArtifact@1
inputs:
Expand Down
8 changes: 4 additions & 4 deletions build/templates/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,12 @@ steps:

if ('${{ parameters.preRelease }}' -eq 'True') {
Write-Host 'Publishing as pre-release'
Write-Host "Executing: npx vsce publish --pat *** --packagePath $vsixPath --manifestPath $manifestPath --signaturePath $signaturePath --pre-release"
npx vsce publish --pat $aadToken --packagePath $vsixPath --manifestPath $manifestPath --signaturePath $signaturePath --pre-release
Write-Host "Executing: npx @vscode/vsce@latest publish --pat *** --packagePath $vsixPath --manifestPath $manifestPath --signaturePath $signaturePath --pre-release"
npx @vscode/vsce@latest publish --pat $aadToken --packagePath $vsixPath --manifestPath $manifestPath --signaturePath $signaturePath --pre-release
} else {
Write-Host 'Publishing as stable release'
Write-Host "Executing: npx vsce publish --pat *** --packagePath $vsixPath --manifestPath $manifestPath --signaturePath $signaturePath"
npx vsce publish --pat $aadToken --packagePath $vsixPath --manifestPath $manifestPath --signaturePath $signaturePath
Write-Host "Executing: npx @vscode/vsce@latest publish --pat *** --packagePath $vsixPath --manifestPath $manifestPath --signaturePath $signaturePath"
npx @vscode/vsce@latest publish --pat $aadToken --packagePath $vsixPath --manifestPath $manifestPath --signaturePath $signaturePath
}

if ($LASTEXITCODE -ne 0) {
Expand Down
14 changes: 0 additions & 14 deletions build/templates/setup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,6 @@ parameters:

steps:
- ${{ if eq(parameters.installNode, true) }}:
- pwsh: |
if (-not (Test-Path '.npmrc')) {
Write-Host 'No .npmrc found, creating one with public npm registry'
@"
# Force public npm registry to avoid CI auth (E401) when no token is provided
registry=https://registry.npmjs.org/
# Do not require auth for public installs
always-auth=false
"@ | Out-File -FilePath '.npmrc' -Encoding utf8
} else {
Write-Host '.npmrc already exists'
}
displayName: Ensure .npmrc exists

- task: npmAuthenticate@0
inputs:
workingFile: .npmrc
Expand Down
Loading