Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review/Comment Suggestions are offset by one line if you make local changes first #6566

Merged
merged 1 commit into from
Dec 18, 2024
+3 −3
Merged

Review/Comment Suggestions are offset by one line if you make local changes first #6566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/common/diffPositionMapping.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,14 @@ export function mapNewPositionToOld(patch: string, line: number): number {
} else {
// Part of the hunk is before line, part is after.
for (const diffLine of diffHunk.diffLines) {
if (diffLine.newLineNumber > line) {
return line + delta;
}
if (diffLine.type === DiffChangeType.Add) {
delta--;
} else if (diffLine.type === DiffChangeType.Delete) {
delta++;
}
if (diffLine.newLineNumber > line) {
return line + delta;
}
}
return line + delta;
}
Expand Down