Skip to content

Commit

Permalink
Use different stop icon for ❇
Browse files Browse the repository at this point in the history
Fixes #6526
  • Loading branch information
alexr00 committed Dec 13, 2024
1 parent fb9890a commit 9a7cdac
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
1 change: 1 addition & 0 deletions resources/icons/stop-circle.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion resources/icons/stop.svg

This file was deleted.

2 changes: 1 addition & 1 deletion webviews/components/icon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,4 @@ export const labelIcon = <Icon src={require('../../resources/icons/label.svg')}
export const milestoneIcon = <Icon src={require('../../resources/icons/milestone.svg')} />;
export const projectIcon = <Icon src={require('../../resources/icons/github-project.svg')} />;
export const sparkleIcon = <Icon src={require('../../resources/icons/sparkle.svg')} />;
export const stopIcon = <Icon src={require('../../resources/icons/stop.svg')} />;
export const stopCircleIcon = <Icon src={require('../../resources/icons/stop-circle.svg')} />;
4 changes: 2 additions & 2 deletions webviews/createPullRequestViewNew/app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import PullRequestContextNew from '../common/createContextNew';
import { ErrorBoundary } from '../common/errorBoundary';
import { LabelCreate } from '../common/label';
import { ContextDropdown } from '../components/contextDropdown';
import { assigneeIcon, labelIcon, milestoneIcon, prBaseIcon, prMergeIcon, projectIcon, reviewerIcon, sparkleIcon, stopIcon } from '../components/icon';
import { assigneeIcon, labelIcon, milestoneIcon, prBaseIcon, prMergeIcon, projectIcon, reviewerIcon, sparkleIcon, stopCircleIcon } from '../components/icon';
import { Avatar } from '../components/user';

type CreateMethod = 'create-draft' | 'create' | 'create-automerge-squash' | 'create-automerge-rebase' | 'create-automerge-merge';
Expand Down Expand Up @@ -240,7 +240,7 @@ export function main() {
</input>
{ctx.createParams.generateTitleAndDescriptionTitle ?
isGeneratingTitle ?
<a title='Cancel' className={`title-action icon-button${isBusy || !ctx.initialized ? ' disabled' : ''}`} onClick={ctx.cancelGenerateTitle} tabIndex={0}>{stopIcon}</a>
<a title='Cancel' className={`title-action icon-button${isBusy || !ctx.initialized ? ' disabled' : ''}`} onClick={ctx.cancelGenerateTitle} tabIndex={0}>{stopCircleIcon}</a>
: <a title={ctx.createParams.generateTitleAndDescriptionTitle} className={`title-action icon-button${isBusy || !ctx.initialized ? ' disabled' : ''}`} onClick={() => generateTitle()} tabIndex={0}>{sparkleIcon}</a> : null}
<div id='title-error' className={params.showTitleValidationError ? 'validation-error below-input-error' : 'hidden'}>A title is required</div>
</div>
Expand Down

0 comments on commit 9a7cdac

Please sign in to comment.