Improve handling of varios reviewer types (#6509)

Part of #6090
microsoft · Dec 4, 2024 · 3855f0f · 3855f0f
1 parent 884227a
commit 3855f0f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/src/github/pullRequestModel.ts b/src/github/pullRequestModel.ts
@@ -988,7 +988,7 @@ export class PullRequestModel extends IssueModel<PullRequest> implements IPullRe
 				input: {
 					pullRequestId: this.graphNodeId,
 					teamIds: teamReviewers,
-					userIds: reviewers
+					userIds: reviewers.filter(r => !r.startsWith('BOT')),
 				},
 			},
 		});

diff --git a/src/github/queriesShared.gql b/src/github/queriesShared.gql
@@ -126,13 +126,14 @@ fragment Review on PullRequestReview {
 		login
 		avatarUrl
 		url
+		... on Node {
+			id
+		}
 		... on User {
 			email
-			id
 		}
 		... on Organization {
 			email
-			id
 		}
 	}
 	state
@@ -318,20 +319,23 @@ query GetReviewRequestsAdditionalScopes($owner: String!, $name: String!, $number
 			reviewRequests(first: 100) {
 				nodes {
 					requestedReviewer {
-						... on User {
+						... on Node {
+							id
+						}
+						... on Actor {
 							login
 							avatarUrl
-							id
+						}
+						... on User {
 							url
 							email
 							name
 						}
-						... on Team {
+						... on Team { # Team is not an Actor
 							name
 							avatarUrl
 							url
 							slug
-							id
 						}
 					}
 				}