-
Notifications
You must be signed in to change notification settings - Fork 141
Add Azure deployment support for DTS projects #4566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions into mwf/convinced-gray
…ions into mwf/convinced-gray
nturinski
reviewed
Jul 14, 2025
src/commands/appSettings/connectionSettings/durableTaskScheduler/DTSConnectionSetSettingStep.ts
Outdated
Show resolved
Hide resolved
nturinski
reviewed
Jul 14, 2025
src/commands/appSettings/connectionSettings/durableTaskScheduler/validateDTSConnection.ts
Outdated
Show resolved
Hide resolved
nturinski
reviewed
Jul 14, 2025
src/commands/appSettings/connectionSettings/durableTaskScheduler/validateDTSConnection.ts
Outdated
Show resolved
Hide resolved
nturinski
reviewed
Jul 14, 2025
nturinski
reviewed
Jul 14, 2025
src/commands/identity/listUserAssignedIdentities/FunctionAppUserAssignedIdentitiesListStep.ts
Show resolved
Hide resolved
nturinski
previously approved these changes
Jul 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think everything else looks pretty good to me
Apparently base branch changing stales the review :( |
41cf2c6
to
8c57cc0
Compare
8c57cc0
to
caa24ca
Compare
nturinski
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High level flow - if DTS project detected, check for necessary DTS app settings on the function app. If missing, prompt user to select existing or create new DTS. Then:
Then resume deploy.
Of special note, I created a new
FunctionAppUserAssignedIdentitiesListStep
that can be used going forward to select existing function app identities to assign new roles to. It is currently missing the ability to create and assign new identities, which is a todo, but it works fine for selecting identities that are already associated with the function app. This PR is already pretty chonky as is so we can explore that implementation later.Related: https://github.com/microsoft/azcode-internal/issues/212
Todo: