Skip to content

Add Azure deployment support for DTS projects #4566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 59 commits into from
Jul 15, 2025
Merged

Conversation

MicroFish91
Copy link
Contributor

@MicroFish91 MicroFish91 commented Jun 23, 2025

High level flow - if DTS project detected, check for necessary DTS app settings on the function app. If missing, prompt user to select existing or create new DTS. Then:

  • Prompt the user for a connected user assigned identity
  • Add Durable Task Contributor role if missing
  • Prepare that connection

Then resume deploy.

Of special note, I created a new FunctionAppUserAssignedIdentitiesListStep that can be used going forward to select existing function app identities to assign new roles to. It is currently missing the ability to create and assign new identities, which is a todo, but it works fine for selecting identities that are already associated with the function app. This PR is already pretty chonky as is so we can explore that implementation later.

Related: https://github.com/microsoft/azcode-internal/issues/212

Todo:

  • Better activity log integration coming in follow-up PR (Add DTS deploy activity log integration #4574)
  • I need to improve the logic so that it doesn't hard code the default connection keys (upcoming PR - this ended up being a somewhat extensive refactor but it will be much cleaner)
  • Create and assign new UAID in the new list step? (upcoming PR)

@MicroFish91 MicroFish91 marked this pull request as ready for review July 14, 2025 19:31
@MicroFish91 MicroFish91 requested a review from a team as a code owner July 14, 2025 19:31
nturinski
nturinski previously approved these changes Jul 14, 2025
Copy link
Member

@nturinski nturinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think everything else looks pretty good to me

Base automatically changed from mwf/convinced-gray to main July 15, 2025 17:33
@MicroFish91 MicroFish91 dismissed nturinski’s stale review July 15, 2025 17:33

The base branch was changed.

@MicroFish91
Copy link
Contributor Author

Apparently base branch changing stales the review :(

@MicroFish91 MicroFish91 merged commit c942bf7 into main Jul 15, 2025
2 checks passed
@MicroFish91 MicroFish91 deleted the mwf/deploy-dts branch July 15, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants