Cache string creation for logging. (#57)

microsoft · Nov 21, 2024 · 7579e66 · 7579e66
1 parent da170de
commit 7579e66
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/rt/debug/logging.h b/src/rt/debug/logging.h
@@ -65,7 +65,7 @@ namespace Logging
   };
 
   // Filled in later by the scheduler thread
-  std::string get_systematic_id();
+  const std::string& get_systematic_id();
 
   class LocalLog : public snmalloc::Pooled<LocalLog>
   {

diff --git a/src/rt/sched/schedulerthread.h b/src/rt/sched/schedulerthread.h
@@ -328,7 +328,7 @@ namespace Logging
 {
   using namespace verona::rt;
 
-  inline std::string get_systematic_id()
+  inline std::string create_systematic_id()
   {
 #if defined(USE_SYSTEMATIC_TESTING) || defined(USE_FLIGHT_RECORDER)
     static std::atomic<size_t> external_id_source = 1;
@@ -367,4 +367,10 @@ namespace Logging
     return "";
 #endif
   }
+
+  inline const std::string& get_systematic_id()
+  {
+    static thread_local std::string id = create_systematic_id();
+    return id;
+  }
 }