[apr] Add HOST_TOOLS_DIR/gen_test_char for cross-compiling to Windows #41416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangWeiLin-MV
added
category:port-bug
LilyWangLL
approved these changes
Oct 10, 2024
Comment on lines
+10
to
+14
| { | ||
| "name": "apr", | ||
| "host": true, | ||
| "platform": "windows" | ||
| }, |
There was a problem hiding this comment.
I thought that this dependency was only needed on cross compiling? This would make it a host dependency even when not cross compiling.
There was a problem hiding this comment.
This is the apr manifest. An apr host dependency is a no-op in the native case.
There was a problem hiding this comment.
You're right @dg0yt, apologies for the confusion.
| "description": "Apache ActiveMQ is the most popular and powerful open source messaging and Integration Patterns server.", | ||
| "license": "Apache-2.0", | ||
| "supports": "!(uwp | osx)", | ||
| "supports": "(windows & !uwp & (x86 | x64)) | (!windows & !osx)", |
There was a problem hiding this comment.
Are you trying to exclude arm on windows?
There was a problem hiding this comment.
Port
activemq-cpp: Only allow x86 and x64 under Windows platform
Yes, only x86 x64 is provided in its sln file of the port activemq-cpp, and it previously was skipped by cascade in CI.
LilyWangLL
removed
the
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #40827, missing native tool
gen_test_charon cross-compiling to Windows.Change
gen_test_charfor cross-compiling to Windowsgen_test_charUNOFFICIAL_APR_HOST_TOOLS_DIRadnUNOFFICIAL_APR_HOST_EXECUTABLE_SUFFIXto set the host toolmingwfrom thesupportsShellapi.hmingwhttps://bz.apache.org/bugzilla/show_bug.cgi?id=56342activemq-cpp: Only allow x86 and x64 under Windows platformFor cross-compiling on Linux, see apache/apr#8
Checklist
The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.Test
The port usage tests pass on host
x64-windowswith the following triplets: