Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mxml] New Port #39991

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[mxml] New Port #39991

wants to merge 2 commits into from

Conversation

Rossmaxx
Copy link
Contributor

@Rossmaxx Rossmaxx commented Jul 20, 2024

fixes: #19042

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@Rossmaxx
Copy link
Contributor Author

Do note that this PR is incomplete. I don't really know what I'm doing here, so any docs and extra help and info appreciated. Most of what's written here is copied from other ports.

@Rossmaxx
Copy link
Contributor Author

What's with the license fail?

@FrankXie05
Copy link
Contributor

@Rossmaxx Thanks for this PR. I think we need to ask upstream whether to add it to vcpkg. In this way, I can help you complete this PR. :)

@FrankXie05 FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jul 22, 2024
@Rossmaxx
Copy link
Contributor Author

Rossmaxx commented Jul 22, 2024

I think we need to ask upstream whether to add it to vcpkg

I did ask about this upstream some time ago, and here's what the maintainer said. Forgot that i asked this in the first place.

michaelrsweet/mxml#281 (comment)

I initially asked for cmake support but the maintainer refused. It's after some time that I understand that vcpkg doesn't require ports to be in cmake and other build systems being supported.

I personally need this port for a project which I'm involved with. I'm trying to add msvc support for a previously mingw built application.

For my use case, I am thinking of disabling linux ports as I don't really want to deal with pkg config here. I'll update the vckpg.json when i start working on this again. I'm on a small break now. But i would like to collect as much info on this break.

Thanks for your reply.

"version": "3.3.1",
"homepage": "https://github.com/michaelrsweet/mxml",
"description": "A tiny xml parsing library",
"license": "Apache license 2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"license": "Apache license 2.0"
"license": "Apache-2.0"

@dg0yt
Copy link
Contributor

dg0yt commented Oct 2, 2024

(I don't understand the comments about upstream. No patches, no restriction, no need to ask.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] Mini-XML
3 participants