Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[socket-io-client] Update to latest commit #36226

Merged
merged 10 commits into from
Jan 19, 2024
Merged

[socket-io-client] Update to latest commit #36226

merged 10 commits into from
Jan 19, 2024

Conversation

vipcxj
Copy link
Contributor

@vipcxj vipcxj commented Jan 18, 2024

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@vipcxj
Copy link
Contributor Author

vipcxj commented Jan 18, 2024

@microsoft-github-policy-service agree

@vipcxj vipcxj marked this pull request as draft January 18, 2024 03:03
@vipcxj vipcxj closed this Jan 18, 2024
@vipcxj vipcxj reopened this Jan 18, 2024
@vipcxj vipcxj marked this pull request as ready for review January 18, 2024 03:05
@LilyWangLL LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Jan 18, 2024
@LilyWangLL LilyWangLL marked this pull request as draft January 18, 2024 06:39
@LilyWangLL LilyWangLL marked this pull request as ready for review January 19, 2024 06:05
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jan 19, 2024
@JavierMatosD JavierMatosD merged commit 5c22217 into microsoft:master Jan 19, 2024
15 checks passed
@Nukoooo Nukoooo mentioned this pull request Jan 20, 2024
Closed
@Nukoooo
Copy link
Contributor

Nukoooo commented Jan 20, 2024

@vipcxj Just wanna say thank you for this PR, I was thinking about creating a patch for cmake file at that time, but I had no idea about how to do that, good work :)

Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
@vipcxj @dg0yt @Osyotr
[socket-io-client] Update to latest commit (microsoft#36226)
c8ed197 
* Update socket-io-client to latest commit

* update git-tree

* update hash

* update git-tree

* add patch

* update git-tree

* update patch

* update git-tree

* Update ports/socket-io-client/fix-build.patch

Co-authored-by: Kai Pastor <[email protected]>

* update git-tree

---------

Co-authored-by: Kai Pastor <[email protected]>
TomKatom pushed a commit to TomKatom/vcpkg that referenced this pull request Feb 23, 2024
@vipcxj @dg0yt @TomKatom
[socket-io-client] Update to latest commit (microsoft#36226)
6547b7e 
* Update socket-io-client to latest commit

* update git-tree

* update hash

* update git-tree

* add patch

* update git-tree

* update patch

* update git-tree

* Update ports/socket-io-client/fix-build.patch

Co-authored-by: Kai Pastor <[email protected]>

* update git-tree

---------

Co-authored-by: Kai Pastor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vipcxj @Nukoooo @dg0yt @LilyWangLL @JavierMatosD