Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cubeb] Add new port #26648

Merged
merged 1 commit into from
Sep 6, 2022
Merged

[cubeb] Add new port #26648

merged 1 commit into from
Sep 6, 2022

Conversation

Zopolis4
Copy link
Contributor

@Zopolis4 Zopolis4 commented Sep 2, 2022

Describe the pull request

  • What does your PR do?

    Adds cubeb port

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    Everything except UWP, No

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@FrankXie05 FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 2, 2022
github-actions[bot]
github-actions bot previously approved these changes Sep 2, 2022
ports/cubeb/vcpkg.json Outdated Show resolved Hide resolved
ports/cubeb/portfile.cmake Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot previously approved these changes Sep 2, 2022
versions/c-/cubeb.json Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot previously approved these changes Sep 2, 2022
@FrankXie05
Copy link
Contributor

Log form install-arm-uwp-dbg-out.log:

D:\buildtrees\cubeb\src\9e009830ea-4cc11e5bd0.clean\src\cubeb_winmm.c(102): error C2061: syntax error: identifier 'WAVEHDR'
D:\buildtrees\cubeb\src\9e009830ea-4cc11e5bd0.clean\src\cubeb_winmm.c(109): error C2061: syntax error: identifier 'waveout'

You can get the latest error log here
install-arm-uwp-dbg-out.log

@Zopolis4
Copy link
Contributor Author

Zopolis4 commented Sep 3, 2022

The UWP build problem is something I have encountered before and have reported at mozilla/cubeb#721. I'll update the port if it gets fixed, but for now I've just marked it as incompatible.

ports/cubeb/portfile.cmake Show resolved Hide resolved
ports/cubeb/vcpkg.json Show resolved Hide resolved
@FrankXie05
Copy link
Contributor

The new usage has been successfully tested locally.

cubeb provides CMake targets:

   # this is heuristically generated, and may not be correct 
   find_package(cubeb CONFIG REQUIRED) 
   target_link_libraries(main PRIVATE cubeb::cubeb)
 

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Sep 6, 2022
@dan-shaw dan-shaw merged commit 1912e1a into microsoft:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants