Parallelize ObjectStorageProvider downloads #1485
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After starting to use Boost from vcpkg in our project, the number of used ports jumped from 20 to ~100. Similarly, restoring all packages from an AWS S3 backend jumped from 2 minutes to almos 10 minutes, which is way too long for us.
Since AWS has a rate limit on individual file downloads, but there's no limit on downloading files in parallel, I've decided to parallelize the download process on the
ObjectStorageProvider
level.I hope this doesn't break Google Cloud Storage and Tencent Cloud Object Storage backends, but I have no way of testing them. If needed, I can add a
supports_parallel_downloads()
method toIObjectStorageTool
, and constrain the parallelization to AWS.