[http-client-python] Preserve custom fields when migrating from setup.py to pyproject.toml #8673

Copilot · 2025-10-06T22:10:52Z

Summary

Successfully implemented automatic migration of fields from setup.py to pyproject.toml when generating Python SDKs.

Changes Completed

Latest Changes

Added default Azure SDK repository URL to KEEP_FIELDS for Azure flavor packages instead of hardcoding in template
Clarified regex comment to show it handles both single and double quotes (already working)
Unified URL rendering: all URLs now come from KEEP_FIELDS consistently

Fields Migrated from setup.py

✅ Dependencies - Custom dependencies preserved, tracked deps with higher versions update VERSION_MAP
✅ Keywords - All keywords kept as a set (no duplicates)
✅ Project URLs - All URLs preserved with proper TOML formatting (from both setup.py and pyproject.toml)
⚠️ PACKAGE_PPRINT_NAME - Warning logged if mismatched

Testing

All 5 unit tests passing with caplog verification
Manual validation confirms proper behavior
Template rendering verified with multi-word keys and Azure flavor URLs

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

- Move setup.py removal to after package file serialization - Read both pyproject.toml and setup.py during migration - Add _keep_setuppy_fields() method to parse setup.py - Merge fields from setup.py into pyproject.toml - Update templates for keywords, project.urls - Update README.md reference from setup.py to pyproject.toml Co-authored-by: swathipil <[email protected]>

- Created test_setup_migration.py with comprehensive tests - Tests cover dependencies, keywords, URLs extraction - All tests passing successfully Co-authored-by: swathipil <[email protected]>

packages/http-client-python/generator/pygen/codegen/serializers/general_serializer.py

...tp-client-python/generator/pygen/codegen/templates/packaging_templates/pyproject.toml.jinja2

packages/http-client-python/generator/pygen/codegen/serializers/general_serializer.py

packages/http-client-python/generator/test/unittests/test_setup_migration.py

- Change _keep_pyproject_fields and _keep_setuppy_fields to mutate params - Initialize params with default keywords {"azure", "azure sdk"} - Update _keep_setuppy_fields to parse project_urls instead of url - Log actual dependency version in INFO messages - Remove duplicate keyword filtering (now handled by set) - Update pyproject.toml template to always output keywords from KEEP_FIELDS - Rewrite tests to use caplog for logging verification - Add test for PACKAGE_PPRINT_NAME warning - Add test for isodate version update to 100.0.0 - Update test to check project_urls parsing - Remove test for url field - All tests passing Co-authored-by: swathipil <[email protected]>

packages/http-client-python/generator/pygen/codegen/serializers/general_serializer.py

...tp-client-python/generator/pygen/codegen/templates/packaging_templates/pyproject.toml.jinja2

packages/http-client-python/generator/pygen/codegen/serializers/general_serializer.py

packages/http-client-python/generator/test/unittests/test_setup_migration.py

- Move logger import to top of file - Keep all URLs including Azure SDK URLs - Add quotes around multi-word keys in project.urls - Fix template to have single project.urls section - Update test to use Azure SDK URLs - Update test comment Co-authored-by: swathipil <[email protected]>

github-actions · 2025-10-07T00:00:37Z

All changed packages have been documented.

✅ @typespec/http-client-python

Show changes

`@typespec/http-client-python` - fix ✏️

[http-client-python] Preserve custom fields when migrating from setup.py to pyproject.toml

The logging format was changed in c3ccdbd to log the full dependency string instead of just the name and version. Updated test assertion to match. Co-authored-by: swathipil <[email protected]>

packages/http-client-python/generator/pygen/codegen/serializers/general_serializer.py

packages/http-client-python/generator/test/unittests/test_setup_migration.py

Preserve custom fields during migration from setup.py to pyproject.toml for the http-client-python package.

- Add project.urls preservation from existing pyproject.toml - Simplify multi-word key formatting to single line - Update test to definitively check for quoted multi-word keys Co-authored-by: swathipil <[email protected]>

packages/http-client-python/generator/pygen/codegen/serializers/general_serializer.py

…uotes - Add default Azure SDK repository URL to KEEP_FIELDS for Azure flavor packages - Remove separate repository line from template (now unified with custom URLs) - Update regex comment to clarify it handles both single and double quotes - All URLs now rendered from KEEP_FIELDS consistently Co-authored-by: swathipil <[email protected]>

swathipil · 2025-10-07T00:39:12Z

packages/http-client-python/generator/pygen/codegen/serializers/general_serializer.py

+                    params["KEEP_FIELDS"]["project.keywords"].update(existing_keywords)
+
+            # Keep project URLs
+            if "urls" in loaded_pyproject_toml["project"]:


Add test in autorest.python PR to check additional project.urls are kept

Initial plan

a4baef3

Copilot AI assigned Copilot and swathipil Oct 6, 2025

Copilot started work on behalf of swathipil October 6, 2025 22:11 View session

Copilot AI and others added 2 commits October 6, 2025 22:18

Add unit tests for setup.py to pyproject.toml migration

b30c80b

- Created test_setup_migration.py with comprehensive tests - Tests cover dependencies, keywords, URLs extraction - All tests passing successfully Co-authored-by: swathipil <[email protected]>

Copilot AI changed the title ~~[WIP] [http-client-python] added dependencies are copied over from setup.py to pyproject.toml~~ [http-client-python] Preserve custom fields when migrating from setup.py to pyproject.toml Oct 6, 2025

Copilot AI requested a review from swathipil October 6, 2025 22:28

Copilot finished work on behalf of swathipil October 6, 2025 22:28

swathipil reviewed Oct 6, 2025

View reviewed changes

Copilot started work on behalf of swathipil October 6, 2025 23:12 View session

Copilot AI requested a review from swathipil October 6, 2025 23:20

Copilot finished work on behalf of swathipil October 6, 2025 23:20

swathipil reviewed Oct 6, 2025

View reviewed changes

Copilot started work on behalf of swathipil October 6, 2025 23:46 View session

microsoft-github-policy-service bot added the emitter:client:python Issue for the Python client emitter: @typespec/http-client-python label Oct 6, 2025

Copilot finished work on behalf of swathipil October 6, 2025 23:53

Copilot AI requested a review from swathipil October 6, 2025 23:53

Apply suggestion from @swathipil

c3ccdbd

Copilot started work on behalf of swathipil October 6, 2025 23:58 View session

Update test to match logging format change

b723460

The logging format was changed in c3ccdbd to log the full dependency string instead of just the name and version. Updated test assertion to match. Co-authored-by: swathipil <[email protected]>

Copilot finished work on behalf of swathipil October 7, 2025 00:03

swathipil reviewed Oct 7, 2025

View reviewed changes

Copilot started work on behalf of swathipil October 7, 2025 00:04 View session

swathipil and others added 2 commits October 6, 2025 17:04

Update changeKind to 'fix' for http-client-python

02e48b2

Preserve custom fields during migration from setup.py to pyproject.toml for the http-client-python package.

Copilot AI requested a review from swathipil October 7, 2025 00:08

Copilot finished work on behalf of swathipil October 7, 2025 00:08

swathipil reviewed Oct 7, 2025

View reviewed changes

packages/http-client-python/generator/pygen/codegen/serializers/general_serializer.py Outdated Show resolved Hide resolved

packages/http-client-python/generator/pygen/codegen/serializers/general_serializer.py Outdated Show resolved Hide resolved

Copilot started work on behalf of swathipil October 7, 2025 00:26 View session

Copilot AI requested a review from swathipil October 7, 2025 00:31

Copilot finished work on behalf of swathipil October 7, 2025 00:31

swathipil reviewed Oct 7, 2025

View reviewed changes

swathipil added 2 commits October 6, 2025 18:08

lint

f1770ad

fix test

63c2ac8

msyyc mentioned this pull request Oct 7, 2025

[http-client-python] Preserve custom fields when migrating from setup.py to pyproject.toml Azure/autorest.python#3231

Draft

swathipil added 2 commits October 7, 2025 09:15

fix project url quotes not rendering correctly

1807395

fix test sensitive word

7c0d64f

[http-client-python] Preserve custom fields when migrating from setup.py to pyproject.toml #8673

Are you sure you want to change the base?

[http-client-python] Preserve custom fields when migrating from setup.py to pyproject.toml #8673

Uh oh!

Conversation

Copilot AI commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes Completed

Latest Changes

Fields Migrated from setup.py

Testing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

@typespec/http-client-python - fix ✏️

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

swathipil Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Oct 6, 2025 •

edited

Loading

github-actions bot commented Oct 7, 2025 •

edited

Loading

`@typespec/http-client-python` - fix ✏️