Support encode when generating csharp property in emitter framework #8415
Conversation
commit: |
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
RodgeFu
requested review from
AlitzelMendez,
bterlson,
chrisradek,
markcowl,
timotheeguerin and
witemple-msft
as code owners
packages/emitter-framework/src/csharp/components/property/property.tsx
Outdated
Show resolved
Hide resolved
packages/emitter-framework/src/csharp/components/json-converter/json-converter-resolver.tsx
Show resolved
Hide resolved
packages/emitter-framework/src/csharp/components/json-converter/json-converter-resolver.tsx
Show resolved
Hide resolved
packages/emitter-framework/src/csharp/components/property/property.tsx
Outdated
Show resolved
Hide resolved
packages/emitter-framework/src/csharp/components/json-converter/json-converter.tsx
Outdated
Show resolved
Hide resolved
packages/emitter-framework/src/csharp/components/json-converter/json-converter.tsx
Outdated
Show resolved
Hide resolved
RodgeFu
requested review from
MaryGao,
joheredi,
qiaozha,
timovv and
xirzec
as code owners
| "cross-spawn@>=7.0.0 <7.0.5": "^7.0.5" | ||
| rollup: 4.49.0 # Regression in 4.50.0 https://github.com/rollup/rollup/issues/6099 | ||
| "@alloy-js/core": 0.21.0-dev.8 | ||
| "@alloy-js/csharp": 0.21.0-dev.19 |
There was a problem hiding this comment.
How can I upgrade to use dev alloy-js libraries in this repo? I tried to upgrade all the packages including alloy-js/core and alloy-js/csharp to the dev version but the build would still fail complaining about conflictions with alloy-js/[email protected] which i guess is because other alloy libs are at 0.20.0 version. Then I change to add the override here which fixes the build, but the typespec-azure in pipeline would still complain because it's still at 0.20.0...
There was a problem hiding this comment.
we try not to switch to dev version in main, what we can do is create a feature branch with any pending things and use the pr link until alloy is upgraded
There was a problem hiding this comment.
otherwise if we were to release typespec without alloy first it would break every user of the emitter framework
packages/emitter-framework/src/csharp/components/json-converter/json-converter-resolver.tsx
Outdated
Show resolved
Hide resolved
packages/emitter-framework/src/csharp/components/json-converter/json-converter.tsx
Show resolved
Hide resolved
packages/emitter-framework/src/csharp/components/json-converter/json-converter.tsx
Outdated
Show resolved
Hide resolved
packages/emitter-framework/src/csharp/components/json-converter/json-converter-resolver.tsx
Outdated
Show resolved
Hide resolved
packages/emitter-framework/src/csharp/components/json-converter/json-converter-resolver.tsx
Outdated
Show resolved
Hide resolved
4 participants
Support encode when generating csharp property in emitter framework