[typespec-vscode] Fix openapi3 preview error when path contain space #7353
+156
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzhongl524
requested review from
RodgeFu,
lirenhe,
bterlson,
markcowl,
timotheeguerin,
chrisradek and
AlitzelMendez
as code owners
|
❌ There is undocummented changes. Run The following packages have changes but are not documented.
The following packages have already been documented:
|
RodgeFu
reviewed
May 15, 2025
|
You can try these changes here
|
RodgeFu
reviewed
May 19, 2025
RodgeFu
reviewed
May 19, 2025
| @@ -230,21 +231,18 @@ export function spawnExecution( | |||
| env?: NodeJS.ProcessEnv, | |||
| on?: spawnExecutionEvents, | |||
| ): Promise<ExecOutput> { | |||
| const shell = process.platform === "win32"; | |||
| const cmd = shell && exe.includes(" ") ? `"${exe}"` : exe; | |||
| let stdout = ""; | |||
There was a problem hiding this comment.
the change will impact all the code spawn execution. please ask vender to run a test pass to make sure it doesnt break anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #7281
OpenAPI3 preview reports error when the path contains space