Align the property types and refine the caches for properties #7340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
|
No changes needing a change description found. |
ArcturusZhang
requested review from
m-nash,
JoshLove-msft and
jorgerangel-msft
as code owners
6 tasks
| name: string; | ||
| doc?: string; | ||
| summary?: string; | ||
| // apiVersions: string[]; |
There was a problem hiding this comment.
nit: remove commented code
| | InputHeaderParameter | ||
| | InputBodyParameter; | ||
|
|
||
| export interface InputQueryParameter extends InputModelPropertyTypeBase { |
There was a problem hiding this comment.
Why does this type extend from InputModelProperty? It won't always be on a model, will it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the schema of property to align with definitions in TCGC.
The MTG.Input models are tweaked accordingly as well.