[@typespec/spector] - Modify checks for headers & parameters #4751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarangan12
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
No changes needing a change description found. |
timotheeguerin
approved these changes
Oct 15, 2024
|
You can try these changes here
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a continuation of #4725, while working on removing the handler for the scenarios in the
typespec-azurerepository, I found some scenarios need added fix in thespectorlibrary.This PR consists of 2 changes:
I have tested this change with all the scenarios in both the
typespecandtypespec-azurerepositories. Once this change is merged, I can open the PR for the scenario changes intypespec-azurerepository.Please review and approve this PR. Thanks