http-client-java, unknown map to binary data #4738
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:java
|
No changes needing a change description found. |
|
You can try these changes here
|
There was a problem hiding this comment.
No logic change in this file. Just being a bit more restricted on imports Jackson (only do this when not in sss).
Comment on lines
-32
to
+36
| return ClassType.OBJECT; | ||
| if (JavaSettings.getInstance().isUseObjectForUnknown()) { | ||
| return ClassType.OBJECT; | ||
| } else { | ||
| return ClassType.BINARY_DATA; | ||
| } |
There was a problem hiding this comment.
This is the main code change.
weidongxu-microsoft
requested review from
srnagar,
haolingdong-msft and
XiaofeiCao
as code owners
XiaofeiCao
reviewed
Oct 15, 2024
...n/java/com/type/property/additionalproperties/models/ExtendsUnknownAdditionalProperties.java
Show resolved
Hide resolved
XiaofeiCao
approved these changes
Oct 15, 2024
| @@ -57,6 +57,10 @@ $generateScript = { | |||
| $tspOptions += " --option ""@typespec/http-client-java.api-version=2022-09-01""" | |||
| # exclude preview from service versions | |||
| $tspOptions += " --option ""@typespec/http-client-java.service-version-exclude-preview=true""" | |||
| } elseif ($tspFile -match "type[\\/]array" -or $tspFile -match "type[\\/]dictionary") { | |||
| # TODO https://github.com/Azure/autorest.java/issues/2964 | |||
There was a problem hiding this comment.
Does released services have this case? If they have, do we need to hold on the releases on typespec-java until the issue fixed?
There was a problem hiding this comment.
We've done a test sync, no released lib has it. -- this is pretty rare for service to have body as raw array or dict, and rarer for the element to be unknown.
haolingdong-msft
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4669
Added
use-object-for-unknownto both swagger/typespec flag. Default isfalse, meaning useBinaryData.(we had 2 or 3 GA lib get affected, and may need to use this flag)
Pending issue Azure/autorest.java#2964