[vs-code-extension] add basic snippets for typespec #4737
Conversation
- add snippets for typespec basic constructs - package snippets within vs code extension part of microsoft#4559
|
All changed packages have been documented.
|
|
You can try these changes here
|
| - typespec-vscode | ||
| --- | ||
|
|
||
| feat(vscode): add basic snippets for typespec |
There was a problem hiding this comment.
please don't name things like that this ends up in the changelog. THis should be descriptive markdown
There was a problem hiding this comment.
same for the pr title in general we don't use that git changelog system so its not really necessary
There was a problem hiding this comment.
updated changeset and pr title accordingly
| { | ||
| "Alias": { | ||
| "prefix": "alias", | ||
| "body": "alias ${1:AliasName} = ${0:Expression};", |
There was a problem hiding this comment.
I don't know much about snippet but shouldn't those numbers be in order? Do they not map to which one gets filled first?
There was a problem hiding this comment.
The sequence starts from 1, 2...
0 is a special index which is always the last one to reach. And when you press Tab to 0, the iteration ends.
If there is no 0, then pressing Tab can start over again when you reach the last placeholder.
There was a problem hiding this comment.
I put 0 in all snippets, because those snippets have placeholders which may require free-style input, not just a single construct. For example, in the alias definition, the Expression could be a quite long input instead of just a model name.
microsoft-github-policy-service
bot
added
the
ide
archerzz
changed the title
| }, | ||
| "Operation": { | ||
| "prefix": ["op", "operation"], | ||
| "body": "operation ${1:OperationName}(${2:parameters}): ${0:ReturnType};", |
There was a problem hiding this comment.
Maybe for operation, we can change the template to
| "body": "operation ${1:OperationName}(${2:parameters}): ${0:ReturnType};", | |
| "body": "operation ${1:OperationName}(${0:parameters}): ${2:ReturnType};", |
since the parameters could be multiple inputs
There was a problem hiding this comment.
On the other hand, the ReturnType could be a union.
part of #4559