Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support apiVersion as path parameter #4691

Merged
merged 22 commits into from
Oct 17, 2024
Merged

Conversation

chunyu3
Copy link
Contributor

@chunyu3 chunyu3 commented Oct 11, 2024

Fix #3986
Fix #4673
Fix #4690

  • support api-version is a path parameter. We will add a _apiVersion field in the client, and will use _apiVersion field in CreateXXXMessage
  • When the type of api-version is Enum, we will convert it to string
  • Not to generate constructor for ClientOptionsProvider in stubLibraryVistor.

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Oct 11, 2024
@microsoft microsoft deleted a comment from azure-sdk Oct 16, 2024
@chunyu3
Copy link
Contributor Author

chunyu3 commented Oct 16, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 16, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp.ClientModel

@chunyu3 chunyu3 added this pull request to the merge queue Oct 17, 2024
Merged via the queue into microsoft:main with commit 64f1dba Oct 17, 2024
21 checks passed
@chunyu3 chunyu3 deleted the cadlranch branch October 17, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
4 participants