Fix playground blank screen and formatter (#4549)

microsoft · Sep 26, 2024 · c44e785 · c44e785
1 parent 378c4e0
commit c44e785
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 9 deletions.
diff --git a/.chronus/changes/fix-playground-blank-screen-and-formatter-2024-8-26-12-35-15.md b/.chronus/changes/fix-playground-blank-screen-and-formatter-2024-8-26-12-35-15.md
@@ -0,0 +1,6 @@
+---
+changeKind: internal
+packages:
+  - "@typespec/playground"
+---
+
diff --git a/.gitignore b/.gitignore
@@ -47,6 +47,7 @@ coverage.xml
 .hypothesis/
 .pytest_cache/
 test-results.xml
+test-results/
 
 # Translations
 *.mo

diff --git a/packages/playground-website/e2e/playwright.config.ts b/packages/playground-website/e2e/playwright.config.ts
@@ -19,11 +19,10 @@ const config: PlaywrightTestConfig = {
     trace: "retain-on-failure",
   },
   projects: [
-    // TODO: investigate
-    // {
-    //   name: "chromium",
-    //   use: { browserName: "chromium" },
-    // },
+    {
+      name: "chromium",
+      use: { browserName: "chromium" },
+    },
     {
       name: "firefox",
       use: { browserName: "firefox" },

diff --git a/packages/playground/src/services.ts b/packages/playground/src/services.ts
@@ -45,12 +45,14 @@ function getTypeSpecLanguageConfiguration(): monaco.languages.LanguageConfigurat
 }
 
 export async function registerMonacoLanguage(host: BrowserHost) {
-  if (monaco.languages.getLanguages().some((x) => x.id === "typespec")) {
-    return;
-  }
   monaco.languages.register({ id: "typespec", extensions: [".tsp"] });
   monaco.languages.setLanguageConfiguration("typespec", getTypeSpecLanguageConfiguration());
 
+  if ((window as any).registeredServices) {
+    return;
+  }
+
+  (window as any).registeredServices = true;
   const serverHost: ServerHost = {
     compilerHost: host,
     getOpenDocumentByURL(url: string) {

diff --git a/packages/playground/vite.config.ts b/packages/playground/vite.config.ts
@@ -39,7 +39,7 @@ export default defineConfig({
     },
 
     rollupOptions: {
-      external: externals,
+      external: (id) => externals.some((x) => id.startsWith(x)),
     },
   },
   esbuild: {