detect cookie parameters as metadata

microsoft · Oct 16, 2024 · b9656c3 · b9656c3
1 parent 1682f66
commit b9656c3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/packages/http/src/metadata.ts b/packages/http/src/metadata.ts
@@ -16,6 +16,7 @@ import {
   isBody,
   isBodyIgnore,
   isBodyRoot,
+  isCookieParam,
   isHeader,
   isMultipartBodyProperty,
   isPathParam,
@@ -219,11 +220,12 @@ export function resolveRequestVisibility(
 
 /**
  * Determines if a property is metadata. A property is defined to be
- * metadata if it is marked `@header`, `@query`, `@path`, or `@statusCode`.
+ * metadata if it is marked `@header`, `@cookie`, `@query`, `@path`, or `@statusCode`.
  */
 export function isMetadata(program: Program, property: ModelProperty) {
   return (
     isHeader(program, property) ||
+    isCookieParam(program, property) ||
     isQueryParam(program, property) ||
     isPathParam(program, property) ||
     isStatusCode(program, property)

diff --git a/packages/http/src/payload.ts b/packages/http/src/payload.ts
@@ -15,7 +15,7 @@ import {
 } from "@typespec/compiler";
 import { DuplicateTracker } from "@typespec/compiler/utils";
 import { getContentTypes } from "./content-types.js";
-import { isHeader, isPathParam, isQueryParam, isStatusCode } from "./decorators.js";
+import { isCookieParam, isHeader, isPathParam, isQueryParam, isStatusCode } from "./decorators.js";
 import {
   GetHttpPropertyOptions,
   HeaderProperty,
@@ -259,13 +259,15 @@ function validateBodyProperty(
       modelProperty: (prop) => {
         const kind = isHeader(program, prop)
           ? "header"
-          : (usedIn === "request" || usedIn === "multipart") && isQueryParam(program, prop)
-            ? "query"
-            : usedIn === "request" && isPathParam(program, prop)
-              ? "path"
-              : usedIn === "response" && isStatusCode(program, prop)
-                ? "statusCode"
-                : undefined;
+          : usedIn === "request" && isCookieParam(program, prop)
+            ? "cookie"
+            : (usedIn === "request" || usedIn === "multipart") && isQueryParam(program, prop)
+              ? "query"
+              : usedIn === "request" && isPathParam(program, prop)
+                ? "path"
+                : usedIn === "response" && isStatusCode(program, prop)
+                  ? "statusCode"
+                  : undefined;
 
         if (kind) {
           diagnostics.add(