Skip to content

Commit

Permalink
add missing packages to upload-bundler (#4681)
Browse files Browse the repository at this point in the history
#4678 ended up not working on account of the imports being incorrect.
Unfortunately updating to use the dist directory still causes problems
with ESM resolution (it attempts to import monaco editor since the
playground website is bundled into a single file), so reverting to the
hard-coded list for now to fix #4674

---------

Co-authored-by: Christopher Radek <[email protected]>
  • Loading branch information
chrisradek and Christopher Radek authored Oct 10, 2024
1 parent 5caa913 commit 52beb60
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 2 deletions.
16 changes: 14 additions & 2 deletions eng/tsp-core/scripts/upload-bundler-packages.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,24 @@ import {
bundleAndUploadPackages,
getPackageVersion,
} from "../../../packages/bundle-uploader/dist/src/index.js";
import { TypeSpecPlaygroundConfig } from "../../../packages/playground-website/src/index.js";
import { repoRoot } from "../../common/scripts/helpers.js";

await bundleAndUploadPackages({
repoRoot: repoRoot,
indexName: "typespec",
indexVersion: await getPackageVersion(repoRoot, "@typespec/compiler"),
packages: [...TypeSpecPlaygroundConfig.libraries],
packages: [
"@typespec/compiler",
"@typespec/http",
"@typespec/rest",
"@typespec/openapi",
"@typespec/versioning",
"@typespec/openapi3",
"@typespec/json-schema",
"@typespec/protobuf",
"@typespec/streams",
"@typespec/events",
"@typespec/sse",
"@typespec/xml",
],
});
3 changes: 3 additions & 0 deletions packages/playground-website/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
"@fluentui/react-components": "~9.55.0",
"@fluentui/react-icons": "^2.0.260",
"@typespec/compiler": "workspace:~",
"@typespec/events": "workspace:~",
"@typespec/html-program-viewer": "workspace:~",
"@typespec/http": "workspace:~",
"@typespec/json-schema": "workspace:~",
Expand All @@ -64,8 +65,10 @@
"@typespec/playground": "workspace:~",
"@typespec/protobuf": "workspace:~",
"@typespec/rest": "workspace:~",
"@typespec/sse": "workspace:~",
"@typespec/streams": "workspace:~",
"@typespec/versioning": "workspace:~",
"@typespec/xml": "workspace:~",
"es-module-shims": "~1.10.0",
"react": "~18.3.1",
"react-dom": "~18.3.1"
Expand Down
3 changes: 3 additions & 0 deletions packages/playground-website/src/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ export const TypeSpecPlaygroundConfig = {
"@typespec/json-schema",
"@typespec/protobuf",
"@typespec/streams",
"@typespec/events",
"@typespec/sse",
"@typespec/xml",
],
samples,
} as const;
9 changes: 9 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 52beb60

Please sign in to comment.