Skip to content

Proposed actions for symbol baseline diffs#3717

Open
RyanCavanaugh wants to merge 1 commit intomainfrom
symbolGroups
Open

Proposed actions for symbol baseline diffs#3717
RyanCavanaugh wants to merge 1 commit intomainfrom
symbolGroups

Conversation

@RyanCavanaugh
Copy link
Copy Markdown
Member

I put the "needs investigation" groups at the top. Same procedure as #3540

Copilot AI review requested due to automatic review settings May 5, 2026 19:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a curated groups.md document that categorizes .symbols.diff baseline differences, prioritizing “needs investigation” items similarly to #3540.

Changes:

  • Introduces a new markdown report grouping 473 symbol baseline diffs by change type.
  • Flags several categories as “Needs Investigation” / “Clear bug” and labels others as benign/intentional.
  • Provides per-category lists of affected .symbols.diff files.
Show a summary per file
File Description
groups.md New categorization report for symbol baseline diffs, with investigation/benign labels and per-group file lists

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 5

Comment thread groups.md
Comment thread groups.md
Comment thread groups.md
Comment thread groups.md
Comment thread groups.md
Comment thread groups.md
Comment on lines +23 to +27
conformance/callSignaturesWithParameterInitializers2.symbols.diff
conformance/stringLiteralTypesInImplementationSignatures2.symbols.diff
conformance/symbolDeclarationEmit12.symbols.diff
conformance/symbolProperty44.symbols.diff
compiler/methodSignatureHandledDeclarationKindForSymbol.symbols.diff
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all error cases with duplicate decls, so showing only one is really not a big deal as there's an error message and dts emit emitting (correctly) just one is not a problem

Comment thread groups.md
Comment on lines +32 to +33
conformance/jsdocImportTypeReferenceToCommonjsModule.symbols.diff
conformance/jsdocImportTypeReferenceToESModule.symbols.diff
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are new error cases:

==== ex.d.ts (0 errors) ====
    declare var config: {
        fix: boolean
    }
    export = config;
    
==== test.js (1 errors) ====
    /** @param {import('./ex')} a */
                ~~~~~~~~~~~~~~
!!! error TS1340: Module './ex' does not refer to a type, but is used as a type here. Did you mean 'typeof import('./ex')'?
    function demo(a) {
        a.fix
    }
    

So fixing the error diff (which is not accepted) would fix this. But I seem to recall that this error diff was intentional

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I remember @sandersn bringing this up. I don't mind being more strict about type/value confusion like this, but it seems like we've walked back a lot of similar breaks since then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants