Skip to content

Replace most ID usage with pointers#3362

Draft
jakebailey wants to merge 5 commits into
mainfrom
jabaile/less-ids
Draft

Replace most ID usage with pointers#3362
jakebailey wants to merge 5 commits into
mainfrom
jabaile/less-ids

Conversation

@jakebailey

Copy link
Copy Markdown
Member

We don't need IDs for comparability in Go; we can use the pointer in pretty much all cases, saving loads.

@jakebailey

Copy link
Copy Markdown
Member Author

@typescript-bot perf test this faster

@typescript-bot

typescript-bot commented Apr 8, 2026

Copy link
Copy Markdown

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
perf test this faster ✅ Started 👀 Results

@typescript-bot

Copy link
Copy Markdown

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - native
Errors 4 4 ~ ~ ~ p=1.000 n=6
Symbols 81,815 (± 0.02%) 81,804 (± 0.02%) ~ 81,781 81,827 p=0.332 n=6
Types 98,821 98,821 ~ ~ ~ p=1.000 n=6
Memory Used 174,707k (± 0.03%) 174,816k (± 0.06%) +109k (+ 0.06%) 174,712k 175,005k p=0.031 n=6
Memory Allocs 1,771,567 (± 0.02%) 1,762,352 (± 0.02%) -9,215 (- 0.52%) 1,761,825 1,762,807 p=0.005 n=6
Config Time 0.000s 0.000s ~ ~ ~ p=1.000 n=6
Parse Time 0.059s (± 5.50%) 0.059s (± 6.44%) ~ 0.055s 0.064s p=0.935 n=6
Bind Time 0s 0s ~ ~ ~ p=1.000 n=6
Check Time 0s 0s ~ ~ ~ p=1.000 n=6
Emit Time 0.854s (± 0.62%) 0.843s (± 1.41%) ~ 0.834s 0.863s p=0.173 n=6
Total Time 0.914s (± 0.74%) 0.902s (± 1.71%) ~ 0.889s 0.927s p=0.229 n=6
angular-1 - native
Errors 2 2 ~ ~ ~ p=1.000 n=6
Symbols 884,654 (± 0.12%) 884,833 (± 0.07%) ~ 883,750 885,449 p=1.000 n=6
Types 263,842 (± 0.00%) 263,842 (± 0.00%) ~ 263,840 263,845 p=0.654 n=6
Memory Used 835,729k (± 0.06%) 836,217k (± 0.09%) ~ 835,042k 837,532k p=0.230 n=6
Memory Allocs 6,716,687 (± 0.23%) 6,712,236 (± 0.11%) ~ 6,697,659 6,717,634 p=0.689 n=6
Config Time 0.028s (± 2.70%) 0.028s (± 3.04%) ~ 0.027s 0.029s p=0.432 n=6
Parse Time 0.246s (± 5.83%) 0.241s (± 6.30%) ~ 0.218s 0.259s p=0.873 n=6
Bind Time 0s 0s ~ ~ ~ p=1.000 n=6
Check Time 0s 0s ~ ~ ~ p=1.000 n=6
Emit Time 1.896s (± 1.05%) 1.917s (± 0.78%) ~ 1.893s 1.935s p=0.078 n=6
Total Time 2.172s (± 1.25%) 2.188s (± 0.70%) ~ 2.167s 2.209s p=0.261 n=6
mui-docs - native
Errors 3 3 ~ ~ ~ p=1.000 n=6
Symbols 4,262,286 4,262,286 ~ ~ ~ p=1.000 n=6
Types 1,537,275 1,537,275 ~ ~ ~ p=1.000 n=6
Memory Used 5,420,081k (± 0.04%) 5,443,848k (± 0.07%) +23,767k (+ 0.44%) 5,439,652k 5,448,579k p=0.005 n=6
Memory Allocs 101,039,389 (±20.35%) 96,925,070 (±15.78%) ~ 73,687,323 110,824,668 p=0.936 n=6
Config Time 0.022s (± 3.39%) 0.022s (± 2.38%) ~ 0.021s 0.022s p=0.241 n=6
Parse Time 1.135s (±33.33%) 1.011s (±20.31%) ~ 0.688s 1.249s p=0.471 n=6
Bind Time 0.002s 0.002s ~ ~ ~ p=1.000 n=6
Check Time 16.780s (± 0.23%) 16.758s (± 0.36%) ~ 16.694s 16.864s p=0.298 n=6
Emit Time 0.508s (±28.39%) 0.439s (± 3.94%) ~ 0.416s 0.453s p=0.297 n=6
Total Time 18.775s (± 1.74%) 18.641s (± 1.33%) ~ 18.202s 18.898s p=0.873 n=6
self-build-src - native
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,396,619 1,396,619 ~ ~ ~ p=1.000 n=6
Types 442,163 442,163 ~ ~ ~ p=1.000 n=6
Memory Used 1,634,649k (± 0.30%) 1,633,877k (± 0.26%) ~ 1,625,447k 1,636,915k p=0.575 n=6
Memory Allocs 57,251,727 (± 0.13%) 57,273,372 (± 0.09%) ~ 57,193,000 57,328,680 p=0.810 n=6
Config Time 0.018s (±49.85%) 0.014s (±58.23%) ~ 0.006s 0.029s p=0.470 n=6
Parse Time 0.278s (± 5.04%) 0.278s (± 1.54%) ~ 0.273s 0.285s p=0.936 n=6
Bind Time 0.000s 0.000s ~ ~ ~ p=1.000 n=6
Check Time 2.315s (± 1.22%) 2.299s (± 0.69%) ~ 2.269s 2.313s p=0.298 n=6
Emit Time 0.224s (± 8.04%) 0.220s (± 3.00%) ~ 0.208s 0.225s p=1.000 n=6
Total Time 29.639s (± 1.34%) 29.478s (± 0.58%) ~ 29.257s 29.699s p=0.471 n=6
self-compiler - native
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 338,176 338,176 ~ ~ ~ p=1.000 n=6
Types 199,525 199,525 ~ ~ ~ p=1.000 n=6
Memory Used 330,497k (± 0.04%) 330,835k (± 0.04%) +338k (+ 0.10%) 330,635k 330,987k p=0.005 n=6
Memory Allocs 2,552,153 (± 0.03%) 2,551,737 (± 0.04%) ~ 2,550,932 2,553,602 p=0.378 n=6
Config Time 0.001s 0.001s (±34.96%) ~ 0.001s 0.002s p=0.405 n=6
Parse Time 0.133s (± 3.89%) 0.138s (± 4.58%) ~ 0.129s 0.147s p=0.199 n=6
Bind Time 0.000s 0.000s ~ ~ ~ p=1.000 n=6
Check Time 1.378s (± 0.45%) 1.379s (± 0.64%) ~ 1.365s 1.391s p=0.873 n=6
Emit Time 0.081s (± 4.41%) 0.082s (±10.96%) ~ 0.072s 0.097s p=0.747 n=6
Total Time 1.649s (± 0.40%) 1.652s (± 0.86%) ~ 1.637s 1.672s p=0.872 n=6
ts-pre-modules - native
Errors 3 3 ~ ~ ~ p=1.000 n=6
Symbols 752 752 ~ ~ ~ p=1.000 n=6
Types 356 356 ~ ~ ~ p=1.000 n=6
Memory Used 103,313k (± 0.03%) 103,308k (± 0.04%) ~ 103,276k 103,379k p=0.689 n=6
Memory Allocs 111,128 (± 0.43%) 110,651 (± 0.30%) ~ 110,295 111,235 p=0.093 n=6
Config Time 0.001s (±48.94%) 0.001s (±77.38%) ~ 0.000s 0.001s p=0.595 n=6
Parse Time 0.122s (± 5.85%) 0.119s (± 5.61%) ~ 0.111s 0.128s p=0.688 n=6
Bind Time 0s 0s ~ ~ ~ p=1.000 n=6
Check Time 0s 0s ~ ~ ~ p=1.000 n=6
Emit Time 0.000s 0.000s ~ ~ ~ p=1.000 n=6
Total Time 0.123s (± 5.81%) 0.120s (± 5.45%) ~ 0.112s 0.129s p=0.688 n=6
vscode - native
Errors 193 193 ~ ~ ~ p=1.000 n=6
Symbols 6,058,532 6,058,532 ~ ~ ~ p=1.000 n=6
Types 2,289,675 2,289,675 ~ ~ ~ p=1.000 n=6
Memory Used 4,113,456k (± 0.03%) 4,121,967k (± 0.03%) +8,511k (+ 0.21%) 4,120,055k 4,123,338k p=0.005 n=6
Memory Allocs 29,865,138 (± 0.05%) 29,853,017 (± 0.03%) ~ 29,840,400 29,868,418 p=0.128 n=6
Config Time 0.125s (± 9.62%) 0.122s (± 8.57%) ~ 0.107s 0.135s p=0.630 n=6
Parse Time 0.718s (± 1.59%) 0.695s (± 3.02%) 🟩-0.023s (- 3.23%) 0.657s 0.712s p=0.045 n=6
Bind Time 0.108s (± 2.31%) 0.116s (±12.74%) ~ 0.107s 0.146s p=0.125 n=6
Check Time 8.140s (± 0.47%) 8.160s (± 0.56%) ~ 8.117s 8.242s p=0.575 n=6
Emit Time 2.002s (± 2.30%) 1.993s (± 8.00%) ~ 1.678s 2.109s p=0.471 n=6
Total Time 11.114s (± 0.58%) 11.109s (± 0.91%) ~ 10.925s 11.206s p=0.936 n=6
webpack - native
Errors 1,146 1,146 ~ ~ ~ p=1.000 n=6
Symbols 699,634 699,634 ~ ~ ~ p=1.000 n=6
Types 334,753 334,753 ~ ~ ~ p=1.000 n=6
Memory Used 550,493k (± 0.03%) 551,307k (± 0.03%) +814k (+ 0.15%) 551,118k 551,511k p=0.005 n=6
Memory Allocs 4,217,238 (± 0.07%) 4,233,308 (± 0.45%) +16,070 (+ 0.38%) 4,218,739 4,270,951 p=0.013 n=6
Config Time 0.014s (±15.72%) 0.012s (±14.14%) ~ 0.010s 0.014s p=0.157 n=6
Parse Time 0.144s (± 4.10%) 0.145s (± 4.31%) ~ 0.139s 0.156s p=0.810 n=6
Bind Time 0.030s (±26.69%) 0.032s (±25.68%) ~ 0.022s 0.044s p=0.574 n=6
Check Time 1.141s (± 1.02%) 1.145s (± 0.59%) ~ 1.134s 1.155s p=0.630 n=6
Emit Time 0.001s (±34.96%) 0.001s (±38.69%) ~ 0.001s 0.002s p=0.595 n=6
Total Time 1.351s (± 0.97%) 1.357s (± 0.56%) ~ 1.348s 1.366s p=0.377 n=6
xstate-main - native
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 991,165 991,165 ~ ~ ~ p=1.000 n=6
Types 350,724 350,724 ~ ~ ~ p=1.000 n=6
Memory Used 599,925k (± 0.01%) 601,741k (± 0.02%) +1,816k (+ 0.30%) 601,676k 601,951k p=0.005 n=6
Memory Allocs 4,957,136 (± 0.23%) 4,943,936 (± 0.09%) -13,201 (- 0.27%) 4,939,110 4,950,852 p=0.013 n=6
Config Time 0.007s (±27.08%) 0.008s (±18.77%) ~ 0.005s 0.009s p=0.616 n=6
Parse Time 0.137s (± 6.24%) 0.136s (± 2.90%) ~ 0.132s 0.141s p=0.871 n=6
Bind Time 0.038s (±19.89%) 0.032s (±21.86%) ~ 0.025s 0.042s p=0.065 n=6
Check Time 1.122s (± 0.65%) 1.136s (± 1.40%) ~ 1.116s 1.150s p=0.148 n=6
Emit Time 0.001s 0.001s ~ ~ ~ p=1.000 n=6
Total Time 1.308s (± 0.86%) 1.316s (± 0.71%) ~ 1.299s 1.324s p=0.173 n=6
System info unknown
Hosts
  • native
Scenarios
  • Compiler-Unions - native
  • angular-1 - native
  • mui-docs - native
  • self-build-src - native
  • self-compiler - native
  • ts-pre-modules - native
  • vscode - native
  • webpack - native
  • xstate-main - native
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@RyanCavanaugh RyanCavanaugh added this to the Possible Improvement milestone May 20, 2026
# Conflicts:
#	internal/checker/checker.go
#	internal/checker/nodebuilderimpl.go
#	internal/transformers/declarations/transform.go
@jakebailey

Copy link
Copy Markdown
Member Author

@typescript-bot perf test this faster

@typescript-automation

typescript-automation Bot commented Jun 17, 2026

Copy link
Copy Markdown

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
perf test this faster ✅ Started ❌ Results

@typescript-automation

Copy link
Copy Markdown

@jakebailey, the perf run you requested failed. You can check the log here.

@typescript-automation

Copy link
Copy Markdown

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - native
Errors 4 4 ~ ~ ~ p=1.000 n=6
Symbols 81,785 (± 0.03%) 81,761 (± 0.04%) ~ 81,719 81,796 p=0.149 n=6
Types 98,821 98,821 ~ ~ ~ p=1.000 n=6
Memory Used 180,499k (± 0.45%) 180,405k (± 0.31%) ~ 179,557k 180,990k p=0.810 n=6
Memory Allocs 1,577,248 (± 0.02%) 1,567,764 (± 0.04%) -9,484 (- 0.60%) 1,567,006 1,568,500 p=0.005 n=6
Config Time 0.001s 0.000s (±154.76%) 🟩-0.001s (-66.67%) 0.000s 0.001s p=0.025 n=6
Parse Time 0.060s (± 3.72%) 0.059s (± 3.32%) ~ 0.056s 0.061s p=0.933 n=6
Bind Time 0.021s (±16.37%) 0.019s (±19.34%) ~ 0.014s 0.024s p=0.416 n=6
Check Time 0s 0s ~ ~ ~ p=1.000 n=6
Emit Time 0.998s (± 1.02%) 1.020s (± 1.74%) +0.022s (+ 2.20%) 0.995s 1.046s p=0.045 n=6
Total Time 1.081s (± 1.06%) 1.101s (± 1.67%) ~ 1.073s 1.122s p=0.078 n=6
angular-1 - native
Errors 3 3 ~ ~ ~ p=1.000 n=6
Symbols 876,905 (± 0.16%) 876,589 (± 0.11%) ~ 875,421 877,491 p=1.000 n=6
Types 263,750 (± 0.00%) 263,749 (± 0.00%) ~ 263,748 263,750 p=0.256 n=6
Memory Used 830,606k (± 0.07%) 831,073k (± 0.09%) ~ 830,230k 832,154k p=0.230 n=6
Memory Allocs 6,907,060 (± 0.22%) 6,914,778 (± 0.49%) ~ 6,886,929 6,977,300 p=0.936 n=6
Config Time 0.018s (± 4.78%) 0.017s (± 2.38%) ~ 0.017s 0.018s p=0.527 n=6
Parse Time 0.245s (± 5.28%) 0.258s (± 3.91%) ~ 0.245s 0.275s p=0.092 n=6
Bind Time 0.065s (±41.10%) 0.052s (±42.53%) ~ 0.035s 0.083s p=0.374 n=6
Check Time 0s 0s ~ ~ ~ p=1.000 n=6
Emit Time 1.867s (± 1.75%) 1.898s (± 2.14%) ~ 1.828s 1.937s p=0.173 n=6
Total Time 2.207s (± 1.91%) 2.234s (± 1.51%) ~ 2.191s 2.280s p=0.230 n=6
mui-docs - native
Errors 11,245 (± 0.01%) 11,241 (± 0.05%) ~ 11,231 11,246 p=0.146 n=6
Symbols 4,209,747 4,209,747 ~ ~ ~ p=1.000 n=6
Types 1,532,197 1,532,197 ~ ~ ~ p=1.000 n=6
Memory Used 4,965,323k (± 0.03%) 4,984,343k (± 0.06%) +19,020k (+ 0.38%) 4,981,137k 4,988,512k p=0.005 n=6
Memory Allocs 80,737,442 (±12.54%) 68,342,336 (± 1.66%) 🟩-12,395,107 (-15.35%) 66,418,645 69,613,776 p=0.045 n=6
Config Time 0.017s (± 7.26%) 0.017s (± 6.98%) ~ 0.016s 0.019s p=0.344 n=6
Parse Time 0.995s (±12.55%) 0.830s (± 2.34%) 🟩-0.165s (-16.59%) 0.802s 0.853s p=0.020 n=6
Bind Time 0.002s 0.002s ~ ~ ~ p=1.000 n=6
Check Time 16.968s (± 0.38%) 16.988s (± 0.50%) ~ 16.870s 17.101s p=1.000 n=6
Emit Time 0.439s (± 3.49%) 0.458s (± 4.39%) ~ 0.431s 0.474s p=0.256 n=6
Total Time 19.014s (± 0.79%) 19.043s (± 0.34%) ~ 18.965s 19.112s p=1.000 n=6
self-build-src - native
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,394,138 1,394,138 ~ ~ ~ p=1.000 n=6
Types 442,153 442,153 ~ ~ ~ p=1.000 n=6
Memory Used 1,649,178k (± 0.25%) 1,653,851k (± 0.31%) ~ 1,648,825k 1,663,276k p=0.173 n=6
Memory Allocs 55,633,548 (± 0.05%) 55,644,044 (± 0.10%) ~ 55,572,045 55,733,252 p=0.936 n=6
Config Time 0.015s (±28.88%) 0.018s (±41.44%) ~ 0.010s 0.027s p=0.572 n=6
Parse Time 0.255s (± 1.71%) 0.256s (± 2.87%) ~ 0.246s 0.265s p=0.688 n=6
Bind Time 0.000s 0.000s (±244.70%) ~ 0.000s 0.001s p=0.405 n=6
Check Time 2.314s (± 1.05%) 2.320s (± 0.29%) ~ 2.308s 2.327s p=0.575 n=6
Emit Time 0.234s (± 4.95%) 0.238s (± 7.33%) ~ 0.215s 0.263s p=0.575 n=6
Total Time 29.475s (± 0.53%) 29.640s (± 0.78%) ~ 29.351s 29.951s p=0.230 n=6
self-compiler - native
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 337,634 337,634 ~ ~ ~ p=1.000 n=6
Types 199,520 199,520 ~ ~ ~ p=1.000 n=6
Memory Used 332,121k (± 0.01%) 332,395k (± 0.03%) +274k (+ 0.08%) 332,256k 332,519k p=0.005 n=6
Memory Allocs 2,415,930 (± 0.02%) 2,416,078 (± 0.02%) ~ 2,415,634 2,416,836 p=0.575 n=6
Config Time 0.001s 0.001s ~ ~ ~ p=1.000 n=6
Parse Time 0.135s (± 3.35%) 0.132s (± 3.68%) ~ 0.127s 0.139s p=0.296 n=6
Bind Time 0.000s 0.000s ~ ~ ~ p=1.000 n=6
Check Time 1.198s (± 0.79%) 1.200s (± 1.11%) ~ 1.185s 1.222s p=1.000 n=6
Emit Time 0.076s (±10.74%) 0.078s (±14.26%) ~ 0.068s 0.093s p=0.748 n=6
Total Time 1.460s (± 0.81%) 1.453s (± 0.96%) ~ 1.431s 1.471s p=0.470 n=6
ts-pre-modules - native
Errors 3 3 ~ ~ ~ p=1.000 n=6
Symbols 97,488 97,488 ~ ~ ~ p=1.000 n=6
Types 356 356 ~ ~ ~ p=1.000 n=6
Memory Used 133,736k (± 0.02%) 133,726k (± 0.03%) ~ 133,676k 133,794k p=0.575 n=6
Memory Allocs 183,050 (± 0.18%) 182,975 (± 0.28%) ~ 182,482 183,686 p=0.230 n=6
Config Time 0.001s 0.001s ~ ~ ~ p=1.000 n=6
Parse Time 0.114s (± 5.77%) 0.118s (± 5.67%) ~ 0.109s 0.127s p=0.261 n=6
Bind Time 0.038s (±10.88%) 0.039s (±12.92%) ~ 0.031s 0.045s p=0.627 n=6
Check Time 0s 0s ~ ~ ~ p=1.000 n=6
Emit Time 0.000s 0.000s ~ ~ ~ p=1.000 n=6
Total Time 0.156s (± 2.38%) 0.161s (± 5.15%) ~ 0.147s 0.168s p=0.198 n=6
vscode - native
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 6,611,265 6,611,265 ~ ~ ~ p=1.000 n=6
Types 2,347,081 2,347,081 ~ ~ ~ p=1.000 n=6
Memory Used 4,506,607k (± 0.03%) 4,516,712k (± 0.02%) +10,105k (+ 0.22%) 4,515,375k 4,517,967k p=0.005 n=6
Memory Allocs 31,860,307 (± 0.16%) 31,842,171 (± 0.06%) ~ 31,823,354 31,875,231 p=1.000 n=6
Config Time 0.068s (± 7.06%) 0.070s (± 7.26%) ~ 0.063s 0.075s p=0.747 n=6
Parse Time 0.879s (± 4.80%) 0.879s (± 1.94%) ~ 0.854s 0.903s p=1.000 n=6
Bind Time 0.195s (±40.44%) 0.147s (±19.59%) ~ 0.130s 0.205s p=0.470 n=6
Check Time 8.561s (± 0.97%) 8.569s (± 1.30%) ~ 8.478s 8.770s p=0.810 n=6
Emit Time 2.124s (± 9.74%) 2.282s (±11.51%) ~ 1.964s 2.578s p=0.128 n=6
Total Time 11.847s (± 0.83%) 11.966s (± 1.50%) ~ 11.762s 12.198s p=0.230 n=6
webpack - native
Errors 2 2 ~ ~ ~ p=1.000 n=6
Symbols 182,448 182,448 ~ ~ ~ p=1.000 n=6
Types 340 340 ~ ~ ~ p=1.000 n=6
Memory Used 221,259k (± 0.12%) 221,295k (± 0.09%) ~ 221,051k 221,591k p=0.936 n=6
Memory Allocs 1,068,266 (± 0.33%) 1,074,476 (± 0.94%) ~ 1,069,338 1,094,949 p=0.093 n=6
Config Time 0.011s (±14.33%) 0.010s (±13.06%) ~ 0.008s 0.012s p=0.391 n=6
Parse Time 0.151s (± 3.26%) 0.149s (± 4.66%) ~ 0.137s 0.156s p=0.872 n=6
Bind Time 0s 0s ~ ~ ~ p=1.000 n=6
Check Time 0s 0s ~ ~ ~ p=1.000 n=6
Emit Time 0.042s (±18.43%) 0.042s (±16.95%) ~ 0.034s 0.052s p=0.936 n=6
Total Time 0.204s (± 3.25%) 0.201s (± 3.13%) ~ 0.194s 0.209s p=0.568 n=6
xstate-main - native
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,065,023 1,065,023 ~ ~ ~ p=1.000 n=6
Types 389,185 389,185 ~ ~ ~ p=1.000 n=6
Memory Used 643,175k (± 0.02%) 645,378k (± 0.02%) +2,203k (+ 0.34%) 645,265k 645,504k p=0.005 n=6
Memory Allocs 5,067,937 (± 0.17%) 5,063,727 (± 0.12%) ~ 5,057,671 5,073,976 p=0.298 n=6
Config Time 0.005s (±11.05%) 0.005s (± 8.44%) ~ 0.004s 0.005s p=0.595 n=6
Parse Time 0.133s (± 5.62%) 0.137s (± 3.17%) ~ 0.132s 0.144s p=0.335 n=6
Bind Time 0.035s (±25.23%) 0.037s (±29.43%) ~ 0.024s 0.051s p=0.748 n=6
Check Time 1.304s (± 0.76%) 1.317s (± 0.97%) ~ 1.301s 1.335s p=0.109 n=6
Emit Time 0.001s 0.001s ~ ~ ~ p=1.000 n=6
Total Time 1.481s (± 0.67%) 1.500s (± 0.54%) +0.019s (+ 1.28%) 1.486s 1.508s p=0.020 n=6
System info unknown
Hosts
  • native
Scenarios
  • Compiler-Unions - native
  • angular-1 - native
  • mui-docs - native
  • self-build-src - native
  • self-compiler - native
  • ts-pre-modules - native
  • vscode - native
  • webpack - native
  • xstate-main - native
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

# Conflicts:
#	internal/checker/checker.go
#	internal/checker/nodebuilderimpl.go
#	internal/transformers/declarations/transform.go
@jakebailey

Copy link
Copy Markdown
Member Author

@typescript-bot perf test this

@typescript-automation

typescript-automation Bot commented Jul 2, 2026

Copy link
Copy Markdown

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
perf test this ✅ Started 👀 Results

@typescript-automation

Copy link
Copy Markdown

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - native
Errors 4 4 ~ ~ ~ p=1.000 n=6
Symbols 81,781 (± 0.06%) 81,749 (± 0.04%) ~ 81,721 81,813 p=0.378 n=6
Types 98,821 98,821 ~ ~ ~ p=1.000 n=6
Memory Used 180,475k (± 0.56%) 180,681k (± 0.24%) ~ 180,037k 181,062k p=0.810 n=6
Memory Allocs 2,539,328 (± 0.01%) 2,530,514 (± 0.01%) -8,814 (- 0.35%) 2,530,067 2,530,975 p=0.005 n=6
Config Time 0.001s (±48.94%) 0.000s (±244.70%) 🟩-0.001s (-80.00%) 0.000s 0.001s p=0.034 n=6
Parse Time 0.061s (± 4.90%) 0.066s (± 6.77%) ~ 0.059s 0.072s p=0.093 n=6
Bind Time 0.018s (±13.13%) 0.017s (±22.81%) ~ 0.013s 0.022s p=0.747 n=6
Check Time 0s 0s ~ ~ ~ p=1.000 n=6
Emit Time 1.048s (± 1.44%) 1.050s (± 1.25%) ~ 1.028s 1.063s p=0.630 n=6
Total Time 1.129s (± 1.52%) 1.135s (± 1.13%) ~ 1.121s 1.156s p=0.261 n=6
angular-1 - native
Errors 3 3 ~ ~ ~ p=1.000 n=6
Symbols 876,484 (± 0.06%) 875,784 (± 0.19%) ~ 872,947 877,342 p=1.000 n=6
Types 263,954 (± 0.00%) 263,953 (± 0.00%) ~ 263,952 263,956 p=0.562 n=6
Memory Used 831,185k (± 0.12%) 831,136k (± 0.06%) ~ 830,597k 831,721k p=1.000 n=6
Memory Allocs 12,525,540 (± 0.10%) 12,508,515 (± 0.09%) -17,025 (- 0.14%) 12,496,543 12,528,488 p=0.045 n=6
Config Time 0.029s (±11.38%) 0.025s (± 8.48%) ~ 0.023s 0.029s p=0.106 n=6
Parse Time 0.274s (± 1.83%) 0.265s (± 4.06%) ~ 0.249s 0.279s p=0.170 n=6
Bind Time 0.046s (± 5.30%) 0.051s (±29.84%) ~ 0.040s 0.081s p=0.936 n=6
Check Time 0s 0s ~ ~ ~ p=1.000 n=6
Emit Time 2.144s (± 0.68%) 2.148s (± 1.15%) ~ 2.110s 2.182s p=0.810 n=6
Total Time 2.503s (± 0.67%) 2.505s (± 1.02%) ~ 2.464s 2.542s p=0.810 n=6
mui-docs - native
Errors 11,273 (± 0.09%) 11,277 (± 0.07%) ~ 11,262 11,282 p=0.518 n=6
Symbols 4,413,863 4,413,863 ~ ~ ~ p=1.000 n=6
Types 1,513,410 1,513,410 ~ ~ ~ p=1.000 n=6
Memory Used 5,017,006k (± 0.03%) 5,038,949k (± 0.03%) +21,943k (+ 0.44%) 5,037,821k 5,041,987k p=0.005 n=6
Memory Allocs 46,048,926 (± 0.10%) 46,039,307 (± 0.03%) ~ 46,021,344 46,060,384 p=0.936 n=6
Config Time 0.028s (±11.73%) 0.029s (±13.22%) ~ 0.023s 0.032s p=0.871 n=6
Parse Time 0.601s (± 2.43%) 0.586s (± 2.32%) ~ 0.564s 0.603s p=0.229 n=6
Bind Time 0.002s (±22.11%) 0.003s (±14.39%) ~ 0.002s 0.003s p=0.112 n=6
Check Time 19.497s (± 0.59%) 19.429s (± 0.34%) ~ 19.323s 19.517s p=0.298 n=6
Emit Time 0.569s (± 5.20%) 0.594s (± 3.96%) ~ 0.546s 0.604s p=0.807 n=6
Total Time 21.539s (± 0.32%) 21.530s (± 0.44%) ~ 21.414s 21.644s p=1.000 n=6
self-build-src - native
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,394,272 1,394,272 ~ ~ ~ p=1.000 n=6
Types 442,245 442,245 ~ ~ ~ p=1.000 n=6
Memory Used 1,656,645k (± 0.20%) 1,659,463k (± 0.31%) ~ 1,653,034k 1,667,453k p=0.810 n=6
Memory Allocs 97,744,026 (± 0.05%) 97,772,502 (± 0.05%) ~ 97,705,425 97,857,451 p=0.575 n=6
Config Time 0.019s (±29.13%) 0.023s (±13.10%) ~ 0.019s 0.025s p=0.147 n=6
Parse Time 0.255s (± 2.44%) 0.249s (± 1.19%) ~ 0.245s 0.253s p=0.173 n=6
Bind Time 0.000s (±244.70%) 0.001s (±244.70%) ~ 0.000s 0.003s p=1.000 n=6
Check Time 2.684s (± 0.27%) 2.707s (± 0.64%) +0.023s (+ 0.87%) 2.693s 2.732s p=0.005 n=6
Emit Time 0.355s (± 4.00%) 0.356s (± 5.70%) ~ 0.342s 0.396s p=0.810 n=6
Total Time 34.654s (± 0.70%) 34.977s (± 0.89%) ~ 34.510s 35.399s p=0.093 n=6
self-compiler - native
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 337,637 337,637 ~ ~ ~ p=1.000 n=6
Types 199,520 199,520 ~ ~ ~ p=1.000 n=6
Memory Used 332,437k (± 0.04%) 332,653k (± 0.04%) +217k (+ 0.07%) 332,535k 332,858k p=0.045 n=6
Memory Allocs 4,717,787 (± 0.01%) 4,717,388 (± 0.02%) ~ 4,716,121 4,718,092 p=0.471 n=6
Config Time 0.001s 0.001s ~ ~ ~ p=1.000 n=6
Parse Time 0.132s (± 7.27%) 0.127s (± 4.25%) ~ 0.120s 0.135s p=0.295 n=6
Bind Time 0.000s 0.000s ~ ~ ~ p=1.000 n=6
Check Time 1.384s (± 0.88%) 1.382s (± 0.41%) ~ 1.374s 1.391s p=0.936 n=6
Emit Time 0.131s (± 6.89%) 0.131s (± 3.11%) ~ 0.127s 0.137s p=1.000 n=6
Total Time 1.704s (± 1.09%) 1.695s (± 0.81%) ~ 1.681s 1.716s p=0.423 n=6
ts-pre-modules - native
Errors 3 3 ~ ~ ~ p=1.000 n=6
Symbols 97,488 97,488 ~ ~ ~ p=1.000 n=6
Types 356 356 ~ ~ ~ p=1.000 n=6
Memory Used 133,710k (± 0.02%) 133,719k (± 0.02%) ~ 133,671k 133,765k p=0.628 n=6
Memory Allocs 180,052 (± 0.10%) 180,846 (± 0.56%) +794 (+ 0.44%) 180,048 182,751 p=0.020 n=6
Config Time 0.001s 0.001s ~ ~ ~ p=1.000 n=6
Parse Time 0.112s (± 4.82%) 0.113s (± 6.71%) ~ 0.108s 0.128s p=0.871 n=6
Bind Time 0.043s (±13.53%) 0.041s (±10.68%) ~ 0.036s 0.047s p=0.467 n=6
Check Time 0s 0s ~ ~ ~ p=1.000 n=6
Emit Time 0.000s 0.000s ~ ~ ~ p=1.000 n=6
Total Time 0.160s (± 6.32%) 0.158s (± 6.84%) ~ 0.149s 0.179s p=0.574 n=6
vscode - native
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 6,895,716 6,895,716 ~ ~ ~ p=1.000 n=6
Types 2,435,539 2,435,539 ~ ~ ~ p=1.000 n=6
Memory Used 4,696,515k (± 0.01%) 4,708,009k (± 0.04%) +11,494k (+ 0.24%) 4,706,241k 4,710,509k p=0.005 n=6
Memory Allocs 32,405,482 (± 0.15%) 32,401,343 (± 0.10%) ~ 32,365,099 32,452,788 p=0.936 n=6
Config Time 0.076s (± 5.61%) 0.072s (±11.58%) ~ 0.063s 0.085s p=0.335 n=6
Parse Time 0.944s (± 6.42%) 0.921s (± 3.46%) ~ 0.866s 0.954s p=0.575 n=6
Bind Time 0.154s (± 2.86%) 0.159s (± 3.31%) ~ 0.153s 0.167s p=0.147 n=6
Check Time 8.844s (± 0.24%) 8.881s (± 1.80%) ~ 8.758s 9.202s p=0.423 n=6
Emit Time 2.644s (± 0.99%) 2.601s (± 7.50%) ~ 2.223s 2.771s p=0.688 n=6
Total Time 12.679s (± 0.59%) 12.650s (± 0.80%) ~ 12.515s 12.776s p=0.689 n=6
webpack - native
Errors 2 2 ~ ~ ~ p=1.000 n=6
Symbols 184,398 184,398 ~ ~ ~ p=1.000 n=6
Types 340 340 ~ ~ ~ p=1.000 n=6
Memory Used 223,806k (± 0.09%) 223,859k (± 0.18%) ~ 223,546k 224,518k p=0.936 n=6
Memory Allocs 937,508 (± 0.71%) 933,986 (± 0.55%) ~ 927,525 941,875 p=0.471 n=6
Config Time 0.008s (±18.01%) 0.007s (±18.15%) ~ 0.006s 0.009s p=0.094 n=6
Parse Time 0.147s (± 6.47%) 0.143s (± 6.38%) ~ 0.129s 0.153s p=0.748 n=6
Bind Time 0s 0s ~ ~ ~ p=1.000 n=6
Check Time 0s 0s ~ ~ ~ p=1.000 n=6
Emit Time 0.037s (±32.31%) 0.048s (±39.35%) ~ 0.031s 0.076s p=0.199 n=6
Total Time 0.192s (±10.03%) 0.197s (± 5.56%) ~ 0.184s 0.211s p=0.470 n=6
xstate-main - native
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,061,625 1,061,625 ~ ~ ~ p=1.000 n=6
Types 391,325 391,325 ~ ~ ~ p=1.000 n=6
Memory Used 644,736k (± 0.02%) 646,934k (± 0.01%) +2,199k (+ 0.34%) 646,853k 647,033k p=0.005 n=6
Memory Allocs 5,016,334 (± 0.07%) 5,013,885 (± 0.08%) ~ 5,008,212 5,019,087 p=0.471 n=6
Config Time 0.002s 0.003s (±48.94%) ~ 0.002s 0.005s p=0.405 n=6
Parse Time 0.126s (±10.08%) 0.122s (±13.35%) ~ 0.103s 0.151s p=0.423 n=6
Bind Time 0.030s (±21.54%) 0.028s (±30.38%) ~ 0.021s 0.039s p=0.373 n=6
Check Time 1.124s (± 0.83%) 1.133s (± 0.96%) ~ 1.115s 1.146s p=0.172 n=6
Emit Time 0.001s (±48.94%) 0.001s (±48.94%) ~ 0.000s 0.001s p=1.000 n=6
Total Time 1.287s (± 0.62%) 1.289s (± 1.53%) ~ 1.263s 1.319s p=0.688 n=6
System info unknown
Hosts
  • native
Scenarios
  • Compiler-Unions - native
  • angular-1 - native
  • mui-docs - native
  • self-build-src - native
  • self-compiler - native
  • ts-pre-modules - native
  • vscode - native
  • webpack - native
  • xstate-main - native
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

lsp

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-UnionsLSP - native
Req 1 - updateOpen 10ms (± 7.40%) 10ms ~ ~ ~ p=0.598 n=6
Req 2 - geterr 976ms (± 0.98%) 980ms (± 0.61%) ~ 973ms 987ms p=0.470 n=6
Req 3 - references 39ms (± 6.68%) 40ms (±11.04%) ~ 37ms 46ms p=0.797 n=6
Req 4 - navto 18ms (± 4.78%) 18ms (±15.71%) ~ 17ms 24ms p=0.753 n=6
Req 5 - completionInfo count 1,357 1,357 ~ ~ ~ p=1.000 n=6
Req 5 - completionInfo 15ms (± 3.77%) 15ms (± 7.30%) ~ 13ms 16ms p=0.227 n=6
CompilerLSP - native
Req 1 - updateOpen 11ms (± 3.65%) 11ms (± 6.94%) ~ 10ms 12ms p=0.389 n=6
Req 2 - geterr 466ms (± 2.57%) 464ms (± 2.79%) ~ 453ms 489ms p=0.688 n=6
Req 3 - references 47ms (± 6.39%) 46ms (± 5.73%) ~ 43ms 49ms p=0.806 n=6
Req 4 - navto 18ms (± 4.14%) 18ms (± 4.14%) ~ 17ms 19ms p=1.000 n=6
Req 5 - completionInfo count 1,519 1,519 ~ ~ ~ p=1.000 n=6
Req 5 - completionInfo 22ms (± 9.78%) 23ms (±26.62%) ~ 18ms 35ms p=0.936 n=6
System info unknown
Hosts
  • native
Scenarios
  • CompilerLSP - native
  • Compiler-UnionsLSP - native
  • xstate-main-1-LSP - native
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

startup

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
lsp-startup - native
Execution time 4.73ms (±516.54%) 4.78ms (±516.56%) ~ 0.00ms 483.94ms p=0.234 n=600
tsgo-startup - native
Execution time 5.89ms (±516.55%) 5.89ms (±516.55%) -0.00ms (- 0.04%) 0.00ms 595.11ms p=0.000 n=600
System info unknown
Hosts
  • native
Scenarios
  • lsp-startup - native
  • tsgo-startup - native
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants