Skip to content

Port "fix: do not use JSX.ElementChildrenAttribute under jsx: react-jsx or jsx: react-jsxdev" #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakebailey merged 1 commit into from
Jun 5, 2025
+14 −222
Merged

Port "fix: do not use JSX.ElementChildrenAttribute under jsx: react-jsx or jsx: react-jsxdev" #1067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions internal/checker/jsx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1077,6 +1077,10 @@ func (c *Checker) getJsxElementPropertiesName(jsxNamespace *ast.Symbol) string {
}

func (c *Checker) getJsxElementChildrenPropertyName(jsxNamespace *ast.Symbol) string {
if c.compilerOptions.Jsx == core.JsxEmitReactJSX || c.compilerOptions.Jsx == core.JsxEmitReactJSXDev {
// In these JsxEmit modes the children property is fixed to 'children'
return "children"
}
return c.getNameFromJsxElementAttributesContainer(JsxNames.ElementChildrenAttributeNameContainer, jsxNamespace)
}

Expand Down
18 changes: 5 additions & 13 deletions ...ompiler/jsxNamespaceElementChildrenAttributeIgnoredWhenReactJsx(jsx=react-jsx).errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
/test.tsx(1,49): error TS2741: Property 'children' is missing in type '{ offspring: string; }' but required in type '{ children: string; }'.
/test.tsx(3,2): error TS2741: Property 'children' is missing in type '{ offspring: string; }' but required in type '{ children: string; }'.
/test.tsx(5,50): error TS2741: Property 'children' is missing in type '{ offspring: string; }' but required in type '{ children: string; }'.
/test.tsx(7,2): error TS2741: Property 'offspring' is missing in type '{ children: string; }' but required in type '{ offspring: string; }'.


==== /jsx.d.ts (0 errors) ====
Expand All @@ -16,23 +14,17 @@
}
}

==== /test.tsx (3 errors) ====
==== /test.tsx (1 errors) ====
const Title = (props: { children: string }) => <h1>{props.children}</h1>;
~~
!!! error TS2741: Property 'children' is missing in type '{ offspring: string; }' but required in type '{ children: string; }'.
!!! related TS2728 /jsx.d.ts:3:11: 'children' is declared here.

<Title>Hello, world!</Title>;
~~~~~
!!! error TS2741: Property 'children' is missing in type '{ offspring: string; }' but required in type '{ children: string; }'.
!!! related TS2728 /test.tsx:1:25: 'children' is declared here.

const Wrong = (props: { offspring: string }) => <h1>{props.offspring}</h1>;
~~
!!! error TS2741: Property 'children' is missing in type '{ offspring: string; }' but required in type '{ children: string; }'.
!!! related TS2728 /jsx.d.ts:3:11: 'children' is declared here.

<Wrong>Byebye, world!</Wrong>
~~~~~
!!! error TS2741: Property 'offspring' is missing in type '{ children: string; }' but required in type '{ offspring: string; }'.
!!! related TS2728 /test.tsx:5:25: 'offspring' is declared here.

==== /jsx/jsx-runtime.ts (0 errors) ====
export {};
Expand Down
38 changes: 0 additions & 38 deletions ...er/jsxNamespaceElementChildrenAttributeIgnoredWhenReactJsx(jsx=react-jsx).errors.txt.diff
View file
Open in desktop

This file was deleted.

18 changes: 5 additions & 13 deletions ...iler/jsxNamespaceElementChildrenAttributeIgnoredWhenReactJsx(jsx=react-jsxdev).errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
/test.tsx(1,49): error TS2741: Property 'children' is missing in type '{ offspring: string; }' but required in type '{ children: string; }'.
/test.tsx(3,2): error TS2741: Property 'children' is missing in type '{ offspring: string; }' but required in type '{ children: string; }'.
/test.tsx(5,50): error TS2741: Property 'children' is missing in type '{ offspring: string; }' but required in type '{ children: string; }'.
/test.tsx(7,2): error TS2741: Property 'offspring' is missing in type '{ children: string; }' but required in type '{ offspring: string; }'.


==== /jsx.d.ts (0 errors) ====
Expand All @@ -16,23 +14,17 @@
}
}

==== /test.tsx (3 errors) ====
==== /test.tsx (1 errors) ====
const Title = (props: { children: string }) => <h1>{props.children}</h1>;
~~
!!! error TS2741: Property 'children' is missing in type '{ offspring: string; }' but required in type '{ children: string; }'.
!!! related TS2728 /jsx.d.ts:3:11: 'children' is declared here.

<Title>Hello, world!</Title>;
~~~~~
!!! error TS2741: Property 'children' is missing in type '{ offspring: string; }' but required in type '{ children: string; }'.
!!! related TS2728 /test.tsx:1:25: 'children' is declared here.

const Wrong = (props: { offspring: string }) => <h1>{props.offspring}</h1>;
~~
!!! error TS2741: Property 'children' is missing in type '{ offspring: string; }' but required in type '{ children: string; }'.
!!! related TS2728 /jsx.d.ts:3:11: 'children' is declared here.

<Wrong>Byebye, world!</Wrong>
~~~~~
!!! error TS2741: Property 'offspring' is missing in type '{ children: string; }' but required in type '{ offspring: string; }'.
!!! related TS2728 /test.tsx:5:25: 'offspring' is declared here.

==== /jsx/jsx-runtime.ts (0 errors) ====
export {};
Expand Down
38 changes: 0 additions & 38 deletions ...jsxNamespaceElementChildrenAttributeIgnoredWhenReactJsx(jsx=react-jsxdev).errors.txt.diff
View file
Open in desktop

This file was deleted.

28 changes: 0 additions & 28 deletions ...bmodule/compiler/jsxNamespaceNoElementChildrenAttributeReactJsx(jsx=react-jsx).errors.txt
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions ...le/compiler/jsxNamespaceNoElementChildrenAttributeReactJsx(jsx=react-jsx).errors.txt.diff
View file
Open in desktop

This file was deleted.

28 changes: 0 additions & 28 deletions ...dule/compiler/jsxNamespaceNoElementChildrenAttributeReactJsx(jsx=react-jsxdev).errors.txt
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions ...compiler/jsxNamespaceNoElementChildrenAttributeReactJsx(jsx=react-jsxdev).errors.txt.diff
View file
Open in desktop

This file was deleted.