Skip to content

Port "Lookup non-local element factory for reference marking when marking fragment references" #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakebailey merged 1 commit into from
Jun 5, 2025
Merged

Port "Lookup non-local element factory for reference marking when marking fragment references" #1065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions internal/checker/checker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26966,8 +26966,9 @@ func (c *Checker) markJsxAliasReferenced(node *ast.Node /*JsxOpeningLikeElement
// if JsxFragment, additionally mark jsx pragma as referenced, since `getJsxNamespace` above would have resolved to only the fragment factory if they are distinct
if ast.IsJsxOpeningFragment(node) {
file := ast.GetSourceFileOfNode(node)
localJsxNamespace := c.getLocalJsxNamespace(file)
if localJsxNamespace != "" {
entity := c.getJsxFactoryEntity(file.AsNode())
if entity != nil {
localJsxNamespace := ast.GetFirstIdentifier(entity).Text()
flags := ast.SymbolFlagsValue
if !shouldFactoryRefErr {
flags &= ^ast.SymbolFlagsEnum
Expand Down
14 changes: 0 additions & 14 deletions .../baselines/reference/submodule/compiler/jsxFragmentAndFactoryUsedOnFragmentUse.errors.txt
View file
Open in desktop

This file was deleted.

18 changes: 0 additions & 18 deletions ...lines/reference/submodule/compiler/jsxFragmentAndFactoryUsedOnFragmentUse.errors.txt.diff
View file
Open in desktop

This file was deleted.