Port "Narrow types by typeof operands with extra parenthesis" #1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ports changes from a TypeScript pull request to improve the handling of extra parentheses in narrowing type checks.
- Updates expected outputs in test baselines for narrowing types when extra parentheses are used.
- Modifies operand evaluation in the binder to use ast.SkipParentheses, ensuring consistency in narrowing binary expressions.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| testdata/baselines/reference/submodule/compiler/narrowingTypeofParenthesized1.types.diff | Adjusts expected diff output to reflect updated narrowing type behavior. |
| testdata/baselines/reference/submodule/compiler/narrowingTypeofParenthesized1.types | Updates test baseline results to align with new narrowing outcomes. |
| internal/binder/binder.go | Refines narrowing operand evaluation by stripping extra parentheses using ast.SkipParentheses. |
jakebailey
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ports microsoft/TypeScript#60928