Skip to content

Fix Release Notes link to use version-specific URL (closes #12886) #19588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Release Notes link to use version-specific URL (closes #12886) #19588

wants to merge 1 commit into from

Conversation

@AHVSSATHVIK
Copy link

@AHVSSATHVIK AHVSSATHVIK commented Nov 25, 2025

Summary

This PR addresses issue #12886 by adding a click handler for the Release Notes link in the About dialog. Currently, the link points to the generic releases page regardless of the installed version.

Changes Made

  • Modified AboutDialog.xaml to replace the static NavigateUri with a Click event handler (_ReleaseNotesOnClick)
  • This enables dynamic URL generation based on the current application version

Validation Steps

  • Open the About dialog in Windows Terminal
  • Click on Release Notes
  • Verify that the link navigates to the correct version-specific release notes

Related Issues

Closes #12886

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Task It's a feature request, but it doesn't really need a major design. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Nov 25, 2025
DHowett
DHowett requested changes Dec 2, 2025
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I see that your change includes a reference to _ReleaseNotesOnClick but no implementation for that function--especially not one that does anything with the version number.

Did you perhaps miss a file when you committed?

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DHowett DHowett DHowett requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-Terminal The new Windows Terminal.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Notice in UI on updating the Terminal app + Fix a Release Notes link to point to the actual release page and not generic releases page

2 participants

@AHVSSATHVIK @DHowett